Skip to content

Commit 90e925a

Browse files
committed
Fix background task tests colliding
We were creating multiple background tasks with the same progress text on multiple threads
1 parent fd9f230 commit 90e925a

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

rust/tests/backgroundtask.rs

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,25 +10,27 @@ fn session() -> Session {
1010

1111
#[rstest]
1212
fn test_background_task_registered(_session: &Session) {
13-
let task = BackgroundTask::new("test task", false);
13+
let task_progress = "test registered";
14+
let task = BackgroundTask::new(task_progress, false);
1415
BackgroundTask::running_tasks()
1516
.iter()
16-
.find(|t| t.progress_text().as_str() == "test task")
17+
.find(|t| t.progress_text().as_str() == task_progress)
1718
.expect("Task not running");
1819
task.finish();
1920
let still_running = BackgroundTask::running_tasks()
2021
.iter()
21-
.find(|t| t.progress_text().as_str() == "test task")
22+
.find(|t| t.progress_text().as_str() == task_progress)
2223
.is_some();
2324
assert!(!still_running, "Task still running");
2425
}
2526

2627
#[rstest]
2728
fn test_background_task_cancellable(_session: &Session) {
28-
let task = BackgroundTask::new("test task", false);
29+
let task_progress = "test cancellable";
30+
let task = BackgroundTask::new(task_progress, false);
2931
BackgroundTask::running_tasks()
3032
.iter()
31-
.find(|t| t.progress_text().as_str() == "test task")
33+
.find(|t| t.progress_text().as_str() == task_progress)
3234
.expect("Task not running");
3335
task.cancel();
3436
assert!(task.is_cancelled());
@@ -37,9 +39,9 @@ fn test_background_task_cancellable(_session: &Session) {
3739

3840
#[rstest]
3941
fn test_background_task_progress(_session: &Session) {
40-
let task = BackgroundTask::new("test task", false);
42+
let task = BackgroundTask::new("test progress", false);
4143
let first_progress = task.progress_text().to_string();
42-
assert_eq!(first_progress, "test task");
44+
assert_eq!(first_progress, "test progress");
4345
task.set_progress_text("new progress");
4446
let second_progress = task.progress_text().to_string();
4547
assert_eq!(second_progress, "new progress");

0 commit comments

Comments
 (0)