Refactor analysis pipeline completion logic and add support for re-enabling analysis after an abort.

Author: bpotchik

plugins/msvc_rtti/plugin.cpp

@@ -80,7 +80,7 @@ extern "C" {
 		// Run rtti before debug info is applied.
 		msvcMetaWorkflow->Insert("core.module.loadDebugInfo", "plugin.msvc.rttiAnalysis");
 		// Run vft after functions have analyzed (so that the virtual functions have analyzed)
-		msvcMetaWorkflow->Insert("core.module.notifyCompletion", "plugin.msvc.vftAnalysis");
+		msvcMetaWorkflow->Insert("core.module.deleteUnusedAutoFunctions", "plugin.msvc.vftAnalysis");
 		Workflow::RegisterWorkflow(msvcMetaWorkflow);
 
 		return true;

plugins/warp/src/plugin/workflow.rs

@@ -94,6 +94,6 @@ pub fn insert_workflow() {
     module_meta_workflow
         .register_activity(&matcher_activity)
         .unwrap();
-    module_meta_workflow.insert("core.module.notifyCompletion", [MATCHER_ACTIVITY_NAME]);
+    module_meta_workflow.insert("core.module.deleteUnusedAutoFunctions", [MATCHER_ACTIVITY_NAME]);
     module_meta_workflow.register().unwrap();
 }

python/workflow.py

@@ -650,13 +650,6 @@ def run(self):
 		else:
 			return json.loads(core.BNPostWorkflowRequestForBinaryView(self.handle, request))
 
-	def abort(self):
-		request = json.dumps({"command": "abort"})
-		if self.is_function_machine:
-			return json.loads(core.BNPostWorkflowRequestForFunction(self.handle, request))
-		else:
-			return json.loads(core.BNPostWorkflowRequestForBinaryView(self.handle, request))
-
 	def halt(self):
 		request = json.dumps({"command": "halt"})
 		if self.is_function_machine:
@@ -768,7 +761,6 @@ class WorkflowMachineCLI(cmd.Cmd):
 		"d": "dump",
 		"c": "resume",
 		"r": "run",
-		"a": "abort",
 		"h": "halt",
 		"s": "step",
 		"b": "breakpoint",
@@ -854,11 +846,6 @@ def do_run(self, line):
 		status = self.machine.run()
 		print(json.dumps(status, indent=4))
 
-	def do_abort(self, line):
-		"""Abort the workflow machine."""
-		status = self.machine.abort()
-		print(json.dumps(status, indent=4))
-
 	def do_halt(self, line):
 		"""Halt the workflow machine."""
 		status = self.machine.halt()