A boolean variable should have a possible value set {0, 1}

[xusheng6]

In the following code, rcx should have a PVS {0, 1}

Binary: quick bird dances boldly

[plafosse]

This one @CouleeApps might have some code for already.

[xusheng6]

Original binary for reference: bright dragon explores carefully

To achieve the result in the database, one need to:

1. Patch the mov rax, 0x12817497dc2c35c2 at 0x1400553be to nop
2. (Optional) Set the .data section to read-only data

[CouleeApps]

Hongyu and I looked at this today and determined that the expression for rcx here actually does have a PVS of {0,1} which can be seen through the api using current_il_expr.possible_values but the tooltip in the ui shows undetermined on the variable in MLIL (but not SSA or Mapped MLIL). I think that means this is fixed, but will defer to you for whether that actually counts.

[xusheng6]

Yeah I think we can close this. Though I wish to bring #7105 to your attention that our lifting is indeed wrong, and that discrepancy might be causing the UI issue as well.

Also, can you show me the commit that fixes the issue? I somehow feel like we should set the PVS to InSetOfValue instead of a range value set

[CouleeApps]

See https://github.com/Vector35/binaryninja/commit/8755580475242384977529705208664256854288

[xusheng6]

I am closing this as fixed now. Though @hongyu-dev might wish to create a new issue for the UI issue