Helios crash in ViewFrame::updateStackView()

[pjcreath]

Version and Platform (required):

• Binary Ninja Version: 5.2.8085-dev
• Edition: Non-Commercial
• OS: macOS
• OS Version: 15
• CPU Architecture: x64

Bug Description:
BN crashes whenever I try to use Tanto!

Steps To Reproduce:

1. Open the uploaded database (see below).
2. Go to 1000394d8.
3. Go to Tanto view.
4. Click "Create New Slice..."
5. Give it a name like "basic", leaving the slice type as the default Basic Block Slice.
6. Hmm...I don't see any blocks to right-click. Edit: It turns out this is due to being in Linear view.
7. Go to Linear view.
8. Right click on the expression at 1000394d8. Hmm...no Tanto submenu, thus no option to "Include Block in Slice...". Edit: This also is due to being in Linear view.
9. Bring up the command palette and type "slice".
10. Select Tanto - Include Block in Slice.
11. Some stuff seems to update in the cross-references pane, but nothing else.
12. Switch to Tanto view.
13. Poof!

Expected Behavior:
I expected BN not to crash. See the first few comments for additional scenarios (including an actual slice!) that cause crashing, all with the same underlying culprit.

Screenshots/Video Recording:
n/a

Binary:
Sample database used above in zodiac magic falls perfectly. The issue is probably general, though.
Stack trace available in system tale begins digitally.

Additional Information:
Tanto Version: 2.0.1 (updated 2025-04-17)

[pjcreath]

A simpler reproduction sequence is:

1. Open the uploaded database (see below).
2. Go to 1000394d8.
3. Go to Tanto view.
4. Click "Create New Slice..."
5. Give it a name like "graph", changing the slice type to Full Call Graph.
6. Poof!

This gets to ViewFrame::updateStackView() via a different path, but the crash location is the same.

[pjcreath]

It seems that the initial absence of the Tanto contextual menu was due to being in Linear vs. Graph view, but it's still crashy after I get a Tanto view populated with a basic block:

1. Open the uploaded database.
2. Go to 1000394d8.
3. Press space to switch to Graph view.
4. Split the pane to add a view to the right.
5. Set the right pane to Tanto.
6. Click "Create New Slice..."
7. Leave the name blank and the default type of Basic Block Slice.
8. Now you at least get a slice view.
9. Now click on 1000394d8 in the Tanto view.
10. Poof!

Once again ViewFrame::updateStackView() is the culprit.

[ElykDeer]

Minimal repro steps:

1. Have Tanto installed
2. Open any binary
3. Open stack view
4. Create a "Full Call Graph"
5. Poof! Something in the stack view doesn't like how Tanto's setting up that flowgraph.

[plafosse]

This crash was caused by 93779376 @CouleeApps. The code assumes that the view will have an Architecture which isn't true for Tanto Call Graphs.

[CouleeApps]

Fixed in >= 5.2.8229 by better checking for the current Architecture in Stack View.