-
Notifications
You must be signed in to change notification settings - Fork 261
Open
Labels
Component: CoreIssue needs changes to the coreIssue needs changes to the coreEffort: LowIssues require < 1 week of workIssues require < 1 week of workImpact: LowIssue is a papercut or has a good, supported workaroundIssue is a papercut or has a good, supported workaround
Milestone
Description
Version and Platform (required):
- Binary Ninja Version: 5.2.8461-dev (but likely goes all the way back)
- Edition: Ultimate
- OS: macOS
- OS Version: 15.6
- CPU Architecture: M1
Bug Description:
When re-analysis is done on a function, all of its auto tags (eg "unimplemented instruction") are cleared and recreated. This leads to new tags being created with identical information but a new randomly chosen id, leading to unnecessary database size increase.
Steps To Reproduce:
- Open file which generates auto tags (like invalid instruction)
- Analyze and wait
- Save
- Reanalyze all
- Save
- Observe that functions with auto tags get their tag ids randomized despite nothing else changing
Screenshots
Additional Information:
A change that addresses this exists but I think it is too spicy to merge this close to release. TLDR make auto generated tag ids deterministic (guid v5)
Metadata
Metadata
Assignees
Labels
Component: CoreIssue needs changes to the coreIssue needs changes to the coreEffort: LowIssues require < 1 week of workIssues require < 1 week of workImpact: LowIssue is a papercut or has a good, supported workaroundIssue is a papercut or has a good, supported workaround