Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Commit ba90800

Browse files
committed
Set default to false, fix setting in Open with Options, minor tweaks to setting language
1 parent 3e7908f commit ba90800

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Plugin.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ BINARYNINJAPLUGIN bool CorePluginInit()
4242
BinaryNinja::LogRegistry::CreateLogger(PluginLoggerName);
4343

4444
auto settings = BinaryNinja::Settings::Instance();
45-
settings->RegisterSetting("core.function.objectiveC.assumeMessageSendTarget",
45+
settings->RegisterSetting("core.function.objectiveC.rewriteMessageSendTarget",
4646
R"({
47-
"title" : "Rewrite objc_msgSend calls to first visible implementation",
47+
"title" : "Rewrite objc_msgSend calls in IL",
4848
"type" : "boolean",
49-
"default" : true,
49+
"default" : false,
5050
"description" : "Message sends of selectors with any visible implementation are replaced with a direct call to the first visible implementation. Note that this can produce false positives if the selector is implemented by more than one class, or shares a name with a method from a system framework."
5151
})");
5252

Workflow.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ bool Workflow::rewriteMethodCall(LLILFunctionRef ssa, size_t insnIndex)
147147
ssa->GetFunction()->SetAutoCallTypeAdjustment(ssa->GetFunction()->GetArchitecture(), insn.address, {funcType, BN_DEFAULT_CONFIDENCE});
148148
// --
149149

150-
if (!BinaryNinja::Settings::Instance()->Get<bool>("core.function.objectiveC.assumeMessageSendTarget"))
150+
if (!BinaryNinja::Settings::Instance()->Get<bool>("core.function.objectiveC.rewriteMessageSendTarget", bv))
151151
return false;
152152

153153
// Check the analysis info for a selector reference corresponding to the

0 commit comments

Comments
 (0)