Skip to content

Commit 1aefe00

Browse files
authored
Fix ncco error (#238)
* Bump version: 3.2.0 → 3.2.1 * fixing import issue with uncommitted init file * adding check that subfolders contain an __init__.py file * refactoring, raising exception
1 parent bfa6cb4 commit 1aefe00

File tree

6 files changed

+18
-3
lines changed

6 files changed

+18
-3
lines changed

.bumpversion.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[bumpversion]
2-
current_version = 3.2.0
2+
current_version = 3.2.1
33
commit = True
44
tag = False
55

CHANGES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# 3.2.1
2+
- Fixing an import bug
3+
14
# 3.2.0
25
- Adding an NCCO Builder to make it easier to work with NCCOs when using the Voice API
36
- Individual NCCO Actions can be created as Pydantic models, which can be built into an NCCO via the `Ncco.build_ncco` method

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
setup(
1313
name="vonage",
14-
version="3.2.0",
14+
version="3.2.1",
1515
description="Vonage Server SDK for Python",
1616
long_description=long_description,
1717
long_description_content_type="text/markdown",

src/vonage/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
from .client import *
22

3-
__version__ = "3.2.0"
3+
__version__ = "3.2.1"

src/vonage/ncco_builder/__init__.py

Whitespace-only changes.

tests/test_packages.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import os
2+
3+
4+
def test_subdirectories_are_python_packages():
5+
subdirs = [
6+
os.path.join('src/vonage', o) for o in os.listdir('src/vonage') if os.path.isdir(os.path.join('src/vonage', o))
7+
]
8+
for subdir in subdirs:
9+
if '__pycache__' in subdir or os.path.isfile(f'{subdir}/__init__.py'):
10+
continue
11+
else:
12+
raise Exception(f'Subfolder {subdir} doesn\'t have an __init__.py file')

0 commit comments

Comments
 (0)