Skip to content

Commit 47b24d4

Browse files
author
Zoltan Herczeg
committed
Implement GC basics
1 parent 30e7b37 commit 47b24d4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+3823
-1815
lines changed

include/wabt/binary-reader-logging.h

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,20 @@ class BinaryReaderLogging : public BinaryReaderDelegate {
4444

4545
Result BeginTypeSection(Offset size) override;
4646
Result OnTypeCount(Index count) override;
47+
Result OnRecursiveType(Index first_type_index, Index type_count) override;
4748
Result OnFuncType(Index index,
4849
Index param_count,
4950
Type* param_types,
5051
Index result_count,
51-
Type* result_types) override;
52-
Result OnStructType(Index index, Index field_count, TypeMut* fields) override;
53-
Result OnArrayType(Index index, TypeMut field) override;
52+
Type* result_types,
53+
GCTypeExtension* gc_ext) override;
54+
Result OnStructType(Index index,
55+
Index field_count,
56+
TypeMut* fields,
57+
GCTypeExtension* gc_ext) override;
58+
Result OnArrayType(Index index,
59+
TypeMut field,
60+
GCTypeExtension* gc_ext) override;
5461
Result EndTypeSection() override;
5562

5663
Result BeginImportSection(Offset size) override;
@@ -432,6 +439,7 @@ class BinaryReaderLogging : public BinaryReaderDelegate {
432439
void LogType(Type type);
433440
void LogTypes(Index type_count, Type* types);
434441
void LogTypes(TypeVector& types);
442+
void LogGCInfo(GCTypeExtension* gc_ext);
435443
void LogField(TypeMut field);
436444

437445
Stream* stream_;

include/wabt/binary-reader-nop.h

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,29 @@ class BinaryReaderNop : public BinaryReaderDelegate {
4545

4646
/* Type section */
4747
Result BeginTypeSection(Offset size) override { return Result::Ok; }
48+
Result OnRecursiveType(Index first_type_index, Index type_count) override {
49+
return Result::Ok;
50+
}
4851
Result OnTypeCount(Index count) override { return Result::Ok; }
4952
Result OnFuncType(Index index,
5053
Index param_count,
5154
Type* param_types,
5255
Index result_count,
53-
Type* result_types) override {
56+
Type* result_types,
57+
GCTypeExtension* gc_ext) override {
5458
return Result::Ok;
5559
}
5660
Result OnStructType(Index index,
5761
Index field_count,
58-
TypeMut* fields) override {
62+
TypeMut* fields,
63+
GCTypeExtension* gc_ext) override {
64+
return Result::Ok;
65+
}
66+
Result OnArrayType(Index index,
67+
TypeMut field,
68+
GCTypeExtension* gc_ext) override {
5969
return Result::Ok;
6070
}
61-
Result OnArrayType(Index index, TypeMut field) override { return Result::Ok; }
6271
Result EndTypeSection() override { return Result::Ok; }
6372

6473
/* Import section */

include/wabt/binary-reader.h

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,20 @@ struct ReadBinaryOptions {
5252
bool skip_function_bodies = false;
5353
};
5454

55-
// TODO: Move somewhere else?
55+
// TODO: Move both TypeMut and GCTypeInformation somewhere else?
5656
struct TypeMut {
5757
Type type;
5858
bool mutable_;
5959
};
6060
using TypeMutVector = std::vector<TypeMut>;
6161

62+
// Garbage Collector specific type information
63+
struct GCTypeExtension {
64+
bool is_final_sub_type;
65+
Index sub_type_count;
66+
Index* sub_types;
67+
};
68+
6269
struct CatchClause {
6370
CatchKind kind;
6471
Index tag;
@@ -99,15 +106,20 @@ class BinaryReaderDelegate {
99106
/* Type section */
100107
virtual Result BeginTypeSection(Offset size) = 0;
101108
virtual Result OnTypeCount(Index count) = 0;
109+
virtual Result OnRecursiveType(Index first_type_index, Index type_count) = 0;
102110
virtual Result OnFuncType(Index index,
103111
Index param_count,
104112
Type* param_types,
105113
Index result_count,
106-
Type* result_types) = 0;
114+
Type* result_types,
115+
GCTypeExtension* gc_ext) = 0;
107116
virtual Result OnStructType(Index index,
108117
Index field_count,
109-
TypeMut* fields) = 0;
110-
virtual Result OnArrayType(Index index, TypeMut field) = 0;
118+
TypeMut* fields,
119+
GCTypeExtension* gc_ext) = 0;
120+
virtual Result OnArrayType(Index index,
121+
TypeMut field,
122+
GCTypeExtension* gc_ext) = 0;
111123
virtual Result EndTypeSection() = 0;
112124

113125
/* Import section */

include/wabt/interp/interp-inl.h

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,30 @@ inline bool FuncType::classof(const ExternType* type) {
4242
}
4343

4444
inline FuncType::FuncType(ValueTypes params, ValueTypes results)
45-
: ExternType(ExternKind::Func), params(params), results(results), func_types(nullptr) {}
45+
: ExternType(ExternKind::Func),
46+
kind(FuncType::TypeKind::Func),
47+
canonical_index(kInvalidIndex),
48+
canonical_sub_index(kInvalidIndex),
49+
is_final_sub_type(true),
50+
recursive_start(0),
51+
recursive_count(0),
52+
params(params),
53+
results(results),
54+
func_types(nullptr) {}
55+
56+
inline FuncType::FuncType(TypeKind kind, ValueTypes params, ValueTypes results)
57+
: ExternType(ExternKind::Func),
58+
kind(kind),
59+
canonical_index(kInvalidIndex),
60+
canonical_sub_index(kInvalidIndex),
61+
is_final_sub_type(true),
62+
recursive_start(0),
63+
recursive_count(0),
64+
params(params),
65+
results(results),
66+
func_types(nullptr) {
67+
assert((kind == TypeKind::Struct || kind == TypeKind::Array) && params.size() == results.size());
68+
}
4669

4770
//// TableType ////
4871
// static

include/wabt/interp/interp.h

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,14 +178,37 @@ struct FuncType : ExternType {
178178
static const ExternKind skind = ExternKind::Func;
179179
static bool classof(const ExternType* type);
180180

181+
enum class TypeKind {
182+
Func,
183+
Struct,
184+
Array,
185+
};
186+
187+
// To simplify the implementation, FuncType may also represent
188+
// Struct and Array types. To do this, the mutability is stored
189+
// in results, which must have the same size as params.
190+
// This implementation might change in the future.
191+
static const Type::Enum Mutable = Type::I32;
192+
static const Type::Enum Immutable = Type::I64;
193+
181194
explicit FuncType(ValueTypes params, ValueTypes results);
195+
explicit FuncType(TypeKind kind, ValueTypes params, ValueTypes results);
182196

183197
std::unique_ptr<ExternType> Clone() const override;
184198

185199
friend Result Match(const FuncType& expected,
186200
const FuncType& actual,
187201
std::string* out_msg);
188202

203+
TypeKind kind;
204+
// These two are needed for fast dynamic type comparison.
205+
Index canonical_index;
206+
Index canonical_sub_index;
207+
// These three are needed for type equality comparisons
208+
// across different modules (import/export validation).
209+
bool is_final_sub_type;
210+
Index recursive_start;
211+
Index recursive_count;
189212
ValueTypes params;
190213
ValueTypes results;
191214
// When params or results contain references, the referenced

include/wabt/ir.h

Lines changed: 43 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,19 @@ enum class TypeEntryKind {
297297
Array,
298298
};
299299

300+
struct TypeEntryGCTypeExtension {
301+
TypeEntryGCTypeExtension(bool is_final_sub_type)
302+
: is_final_sub_type(is_final_sub_type) {}
303+
304+
void InitSubTypes(Index* sub_type_list, Index sub_type_count);
305+
306+
bool is_final_sub_type;
307+
// The binary/text format allows any number of subtypes,
308+
// so parsers must handle them. The validator rejects
309+
// lists which size is greater than 1.
310+
VarVector sub_types;
311+
};
312+
300313
class TypeEntry {
301314
public:
302315
WABT_DISALLOW_COPY_AND_ASSIGN(TypeEntry);
@@ -307,12 +320,17 @@ class TypeEntry {
307320

308321
Location loc;
309322
std::string name;
323+
TypeEntryGCTypeExtension gc_ext;
310324

311325
protected:
312326
explicit TypeEntry(TypeEntryKind kind,
327+
bool is_final_sub_type,
313328
std::string_view name = std::string_view(),
314329
const Location& loc = Location())
315-
: loc(loc), name(name), kind_(kind) {}
330+
: loc(loc),
331+
name(name),
332+
gc_ext(is_final_sub_type),
333+
kind_(kind) {}
316334

317335
TypeEntryKind kind_;
318336
};
@@ -323,8 +341,8 @@ class FuncType : public TypeEntry {
323341
return entry->kind() == TypeEntryKind::Func;
324342
}
325343

326-
explicit FuncType(std::string_view name = std::string_view())
327-
: TypeEntry(TypeEntryKind::Func, name) {}
344+
explicit FuncType(bool is_final_sub_type, std::string_view name = std::string_view())
345+
: TypeEntry(TypeEntryKind::Func, is_final_sub_type, name) {}
328346

329347
Index GetNumParams() const { return sig.GetNumParams(); }
330348
Index GetNumResults() const { return sig.GetNumResults(); }
@@ -353,8 +371,8 @@ class StructType : public TypeEntry {
353371
return entry->kind() == TypeEntryKind::Struct;
354372
}
355373

356-
explicit StructType(std::string_view name = std::string_view())
357-
: TypeEntry(TypeEntryKind::Struct) {}
374+
explicit StructType(bool is_final_sub_type, std::string_view name = std::string_view())
375+
: TypeEntry(TypeEntryKind::Struct, is_final_sub_type, name) {}
358376

359377
std::vector<Field> fields;
360378
};
@@ -365,12 +383,19 @@ class ArrayType : public TypeEntry {
365383
return entry->kind() == TypeEntryKind::Array;
366384
}
367385

368-
explicit ArrayType(std::string_view name = std::string_view())
369-
: TypeEntry(TypeEntryKind::Array) {}
386+
explicit ArrayType(bool is_final_sub_type, std::string_view name = std::string_view())
387+
: TypeEntry(TypeEntryKind::Array, is_final_sub_type, name) {}
370388

371389
Field field;
372390
};
373391

392+
struct RecursiveRange {
393+
Index first_type_index;
394+
Index type_count;
395+
396+
Index EndTypeIndex() const { return first_type_index + type_count; }
397+
};
398+
374399
struct FuncDeclaration {
375400
Index GetNumParams() const { return sig.GetNumParams(); }
376401
Index GetNumResults() const { return sig.GetNumResults(); }
@@ -1107,7 +1132,8 @@ enum class ModuleFieldType {
11071132
Memory,
11081133
DataSegment,
11091134
Start,
1110-
Tag
1135+
Tag,
1136+
EmptyRec
11111137
};
11121138

11131139
class ModuleField : public intrusive_list_base<ModuleField> {
@@ -1234,6 +1260,12 @@ class TagModuleField : public ModuleFieldMixin<ModuleFieldType::Tag> {
12341260
Tag tag;
12351261
};
12361262

1263+
class EmptyRecModuleField : public ModuleFieldMixin<ModuleFieldType::EmptyRec> {
1264+
public:
1265+
explicit EmptyRecModuleField(const Location& loc = Location())
1266+
: ModuleFieldMixin<ModuleFieldType::EmptyRec>(loc) {}
1267+
};
1268+
12371269
class StartModuleField : public ModuleFieldMixin<ModuleFieldType::Start> {
12381270
public:
12391271
explicit StartModuleField(Var start = Var(), const Location& loc = Location())
@@ -1293,6 +1325,7 @@ struct Module {
12931325
void AppendField(std::unique_ptr<ExportModuleField>);
12941326
void AppendField(std::unique_ptr<FuncModuleField>);
12951327
void AppendField(std::unique_ptr<TypeModuleField>);
1328+
void AppendField(std::unique_ptr<EmptyRecModuleField>);
12961329
void AppendField(std::unique_ptr<GlobalModuleField>);
12971330
void AppendField(std::unique_ptr<ImportModuleField>);
12981331
void AppendField(std::unique_ptr<MemoryModuleField>);
@@ -1319,6 +1352,8 @@ struct Module {
13191352
std::vector<Import*> imports;
13201353
std::vector<Export*> exports;
13211354
std::vector<TypeEntry*> types;
1355+
// Ordered list of recursive ranges.
1356+
std::vector<RecursiveRange> recursive_ranges;
13221357
std::vector<Table*> tables;
13231358
std::vector<ElemSegment*> elem_segments;
13241359
std::vector<Memory*> memories;

0 commit comments

Comments
 (0)