refactor: move some filter hooks which refactored with last commit to earlier

Author: Mustafa Şükrü Kapusuz

includes/indices/class-algolia-posts-index.php

@@ -295,7 +295,8 @@ private function get_post_shared_attributes( WP_Post $post ) {
 	 * @return array
 	 */
 	public function get_settings() {
-		return (array) apply_filters( 'algolia_posts_index_settings', parent::get_settings(), $this->post_type );
+		$this->settings = (array) apply_filters( 'algolia_posts_index_settings', $this->settings, $this->post_type );
+		return parent::get_settings();
 	}
 
 	/**

includes/indices/class-algolia-terms-index.php

@@ -139,7 +139,9 @@ protected function get_re_index_items_count() {
 	 * @return array
 	 */
 	public function get_settings() {
-		return apply_filters( 'algolia_terms_index_settings', parent::get_settings(), $this->taxonomy );
+		// override settings prop to have a custom WP filter hook for terms only
+		$this->settings = apply_filters( 'algolia_terms_index_settings', $this->settings, $this->taxonomy );
+		return parent::get_settings();
 	}
 
 	/**