Merge branch 'master' into vulnerability-analyser

Author: seran

core/src/main/kotlin/org/evomaster/core/problem/rest/data/RestCallAction.kt

@@ -1,5 +1,6 @@
 package org.evomaster.core.problem.rest.data
 
+import org.evomaster.core.Lazy
 import org.evomaster.core.problem.httpws.HttpWsAction
 import org.evomaster.core.problem.httpws.auth.HttpWsAuthenticationInfo
 import org.evomaster.core.problem.httpws.auth.HttpWsNoAuth
@@ -71,7 +72,7 @@ class RestCallAction(
      *
      * TODO check if it could be used to handle issue in BackwardLinkReference
      */
-    private var weakReference: RestCallAction? = null
+     private var weakReference: RestCallAction? = null
 ) : HttpWsAction(auth, isCleanUp, parameters) {
 
     companion object{
@@ -367,6 +368,8 @@ class RestCallAction(
             return true // nothing to do
         }
         if(weakReference!!.isMounted()) {
+            //make sure both actions are in the same individual
+            Lazy.assert { this.getRoot() == weakReference!!.getRoot() }
             usePreviousLocationId = weakReference!!.creationLocationId()
             weakReference = null
             return true
@@ -409,4 +412,22 @@ class RestCallAction(
 
         return true
     }
+
+    /**
+     * a copy() on an unresolved action with a weakref will crash.
+     * this is as intended, as weakref would be meaningless when action mounted in a new individual.
+     * however, there are cases in which we need to "duplicate" an action in an individual.
+     * in those cases, we must keep the weakref
+     */
+    fun copyKeepingSameWeakRef() : RestCallAction{
+        if(weakReference == null){
+            return copy() as RestCallAction
+        }
+        val wr = weakReference
+        weakReference = null
+        val copy = this.copy() as RestCallAction
+        copy.weakReference = wr
+        this.weakReference = wr
+        return copy
+    }
 }

core/src/main/kotlin/org/evomaster/core/problem/rest/service/RestIndividualBuilder.kt

@@ -145,7 +145,7 @@ class RestIndividualBuilder {
                     "${template.path} vs ${target.path}")
         }
 
-        val res = template.copy() as RestCallAction
+        val res = template.copyKeepingSameWeakRef()
 
         res.resetLocalIdRecursively()
 
@@ -180,7 +180,7 @@ class RestIndividualBuilder {
                     "${previous.path} vs ${template.path}")
         }
 
-        val res = template.copy() as RestCallAction
+        val res = template.copyKeepingSameWeakRef()
 
         res.resetLocalIdRecursively()