From ac45798ad4fa71b38932987da93d9e62b57f2e39 Mon Sep 17 00:00:00 2001
From: Rafael Funchal <rafaelfunchal@gmail.com>
Date: Tue, 17 Sep 2024 11:58:29 -0700
Subject: [PATCH 1/5] Adding documentation for
 WordPress.Arrays.ArrayDeclarationSpacing

---
 .../ArrayDeclarationSpacingStandard.xml       | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml

diff --git a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
new file mode 100644
index 0000000000..f70bbac505
--- /dev/null
+++ b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
@@ -0,0 +1,51 @@
+<?xml version="1.0"?>
+<documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
+    title="Array Declaration Spacing"
+    >
+    <standard>
+    <![CDATA[
+    When an array uses associative keys, each pair of key and value must start on a new line.
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="Valid: There is only one pair of key and value per line.">
+        <![CDATA[
+$args = array(
+    <em>'post_id' => 22,
+    'category' => 1</em>
+);
+        ]]>
+        </code>
+        <code title="Invalid: More than one pair of key and value per line.">
+        <![CDATA[
+$args = array(
+    <em>'post_id' => 22, 'category' => 1</em>
+);
+        ]]>
+        </code>
+    </code_comparison>
+    <standard>
+    <![CDATA[
+    Each item in a multi-line array must be on a new line.
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="Valid: Only one array item per line.">
+        <![CDATA[
+$args = array(
+    <em>'post_id',
+    'comment_count',
+    'post_type'</em>
+);
+        ]]>
+        </code>
+        <code title="Invalid: Multiple array items in the same line.">
+        <![CDATA[
+$args = array(
+    <em>'post_id', 'comment_count', 'post_type'</em>
+);
+        ]]>
+        </code>
+    </code_comparison>
+</documentation>

From f676769f25615de7e1a3e39b8b605f638696ac2b Mon Sep 17 00:00:00 2001
From: Matt Galdino <matt@phoenixts.com>
Date: Tue, 26 Aug 2025 15:19:21 -0700
Subject: [PATCH 2/5] docs: Use individual <em> tags per line for better
 clarity

---
 .../Docs/Arrays/ArrayDeclarationSpacingStandard.xml    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
index f70bbac505..43ec3d3cef 100644
--- a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
+++ b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
@@ -12,8 +12,8 @@
         <code title="Valid: There is only one pair of key and value per line.">
         <![CDATA[
 $args = array(
-    <em>'post_id' => 22,
-    'category' => 1</em>
+    <em>'post_id' => 22</em>,
+    <em>'category' => 1</em>
 );
         ]]>
         </code>
@@ -34,9 +34,9 @@ $args = array(
         <code title="Valid: Only one array item per line.">
         <![CDATA[
 $args = array(
-    <em>'post_id',
-    'comment_count',
-    'post_type'</em>
+    <em>'post_id'</em>,
+    <em>'comment_count'</em>,
+    <em>'post_type'</em>
 );
         ]]>
         </code>

From 16949aa62f2a3ea43a7647ce058cc179368207ee Mon Sep 17 00:00:00 2001
From: Matt Galdino <matt@phoenixts.com>
Date: Tue, 26 Aug 2025 15:20:17 -0700
Subject: [PATCH 3/5] docs: Change 'associative keys' to 'keys' for clearer
 terminology and Update terminology from 'pair of key and value' to 'key/value
 pair'

---
 WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
index 43ec3d3cef..1b43b159f9 100644
--- a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
+++ b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
@@ -5,11 +5,11 @@
     >
     <standard>
     <![CDATA[
-    When an array uses associative keys, each pair of key and value must start on a new line.
+    When an array uses keys, each key/value pair must start on a new line.
     ]]>
     </standard>
     <code_comparison>
-        <code title="Valid: There is only one pair of key and value per line.">
+        <code title="Valid: There is only one key/value pair per line.">
         <![CDATA[
 $args = array(
     <em>'post_id' => 22</em>,
@@ -17,7 +17,7 @@ $args = array(
 );
         ]]>
         </code>
-        <code title="Invalid: More than one pair of key and value per line.">
+        <code title="Invalid: More than one key/value pair per line.">
         <![CDATA[
 $args = array(
     <em>'post_id' => 22, 'category' => 1</em>

From 6bd80ec1fe237198a753acec221a7b61c52aef9b Mon Sep 17 00:00:00 2001
From: Matt Galdino <matt@phoenixts.com>
Date: Tue, 26 Aug 2025 15:21:03 -0700
Subject: [PATCH 4/5] docs: Add associative array example and clarify
 multi-line array rule

---
 .../ArrayDeclarationSpacingStandard.xml       | 26 ++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
index 1b43b159f9..fcc22e8468 100644
--- a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
+++ b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
@@ -40,10 +40,34 @@ $args = array(
 );
         ]]>
         </code>
-        <code title="Invalid: Multiple array items in the same line.">
+        <code title="Invalid: More than one item per line in a multi-line array.">
         <![CDATA[
 $args = array(
     <em>'post_id', 'comment_count', 'post_type'</em>
+);
+        ]]>
+        </code>
+    </code_comparison>
+    <standard>
+    <![CDATA[
+    Associative arrays with multiple key-value pairs must also follow this rule.
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="Valid: Each key-value pair on its own line.">
+        <![CDATA[
+$settings = array(
+    <em>'width' => 300</em>,
+    <em>'height' => 200</em>,
+    <em>'color' => 'blue'</em>
+);
+        ]]>
+        </code>
+        <code title="Invalid: Multiple key-value pairs on the same line in a multi-line array.">
+        <![CDATA[
+$settings = array(
+    <em>'width' => 300, 'height' => 200</em>,
+    <em>'color' => 'blue'</em>
 );
         ]]>
         </code>

From c2b316cfc4b0e51d7761ed5ce5822016a5ea5b14 Mon Sep 17 00:00:00 2001
From: Matt Galdino <matt@phoenixts.com>
Date: Tue, 26 Aug 2025 15:27:18 -0700
Subject: [PATCH 5/5] docs: Fix code examples to follow WordPress Coding
 Standards

- Add trailing commas after last array items
- Align double arrows for better readability
---
 .../Arrays/ArrayDeclarationSpacingStandard.xml   | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
index fcc22e8468..6ee64b3fab 100644
--- a/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
+++ b/WordPress/Docs/Arrays/ArrayDeclarationSpacingStandard.xml
@@ -12,15 +12,15 @@
         <code title="Valid: There is only one key/value pair per line.">
         <![CDATA[
 $args = array(
-    <em>'post_id' => 22</em>,
-    <em>'category' => 1</em>
+    <em>'post_id'  => 22</em>,
+    <em>'category' => 1</em>,
 );
         ]]>
         </code>
         <code title="Invalid: More than one key/value pair per line.">
         <![CDATA[
 $args = array(
-    <em>'post_id' => 22, 'category' => 1</em>
+    <em>'post_id' => 22, 'category' => 1</em>,
 );
         ]]>
         </code>
@@ -36,14 +36,14 @@ $args = array(
 $args = array(
     <em>'post_id'</em>,
     <em>'comment_count'</em>,
-    <em>'post_type'</em>
+    <em>'post_type'</em>,
 );
         ]]>
         </code>
         <code title="Invalid: More than one item per line in a multi-line array.">
         <![CDATA[
 $args = array(
-    <em>'post_id', 'comment_count', 'post_type'</em>
+    <em>'post_id', 'comment_count', 'post_type'</em>,
 );
         ]]>
         </code>
@@ -57,9 +57,9 @@ $args = array(
         <code title="Valid: Each key-value pair on its own line.">
         <![CDATA[
 $settings = array(
-    <em>'width' => 300</em>,
+    <em>'width'  => 300</em>,
     <em>'height' => 200</em>,
-    <em>'color' => 'blue'</em>
+    <em>'color'  => 'blue'</em>,
 );
         ]]>
         </code>
@@ -67,7 +67,7 @@ $settings = array(
         <![CDATA[
 $settings = array(
     <em>'width' => 300, 'height' => 200</em>,
-    <em>'color' => 'blue'</em>
+    <em>'color' => 'blue'</em>,
 );
         ]]>
         </code>