the misuse of avcodec_encode_audio2?

[syevanchen]

What would you like to submit? (put an 'x' inside the bracket that applies)

• question
• bug report
• feature request

Issue description

If you would like to submit an issue, please include a sample of the code you are trying to execute, as well as any data you might be using in your experiment, such as data tables, images, anything that might be necessary to reproduce the problem.

Note: If you would like to support the development for this feature or resolution of this bug, consider adding a bounty to it later in https://www.bountysource.com/teams/accord-net/issues

when I read the code of 3.7.0, and i find following codes in ffmpeg.cpp, I think the avcodec_encode_audio2 shouldn't use those parameters, isn't it?

int avcodec_encode_audio2 (AVCodecContext *avctx, AVPacket *avpkt, const AVFrame *frame, int *got_packet_ptr)

pkt.size = libffmpeg::avcodec_encode_audio2(codecContext,
(libffmpeg::AVPacket*)data->AudioEncodeBuffer,
(libffmpeg::AVFrame*)data->AudioEncodeBufferSize, (int*)pSoundBuffer);

[cesarsouza]

Hi @syevanchen,

Thanks for opening the issue. Yes, the avcodec_encode_audio2 in VideoFileWriter could be rewritten to use the proper classes from FFMPEG instead of those casts. This functionality was implemented during a time when the project was kind of stuck with a very old version of FFMPEG, and it might be the case that it was implemented this way to circumvent some issue. However, this should not be the case anymore.

If you would like to send a pull request with changes, it would be more than welcome!

Regards,
Cesar

[cesarsouza]

The VideoFileWriter class has been completely rewritten using almost the most recent version of the FFmpeg API, except for the recent send/receive API.

But at least, avcodec_encode_audio2 is now receiving the correct parameters and VideoFileWriter does not crash anymore when receiving parameters it wasn't prepared to receive.

Regards,
Cesar