Skip to content

Commit b8f2d1d

Browse files
committed
Fix reame with error handling
1 parent 9ae0e3a commit b8f2d1d

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export default class FormComponent {
108108
try {
109109
await this.changeset.validate(changes => UserSchema.validate(changes));
110110
} catch (e) {
111-
dummyChangeset.addError(e.path, { value: e.value.age, validation: e.message });
111+
dummyChangeset.addError(e.path, { value: changeset.get(e.path), validation: e.message });
112112
}
113113
}
114114
}

test/validated.test.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1646,7 +1646,7 @@ describe('Unit | Utility | validation changeset', () => {
16461646
try {
16471647
await dummyChangeset.validate(changes => userSchema.validate(changes));
16481648
} catch (e) {
1649-
dummyChangeset.addError(e.path, { value: e.value.age, validation: e.message });
1649+
dummyChangeset.addError(e.path, { value: dummyChangeset.get(e.path), validation: e.message });
16501650
}
16511651
expect(dummyChangeset.isInvalid).toEqual(true);
16521652
expect(dummyChangeset.isValid).toEqual(false);
@@ -1737,7 +1737,7 @@ describe('Unit | Utility | validation changeset', () => {
17371737
try {
17381738
await dummyChangeset.validate(changes => userSchema.validate(changes));
17391739
} catch (e) {
1740-
dummyChangeset.addError(e.path, { value: e.value.age, validation: e.message });
1740+
dummyChangeset.addError(e.path, { value: dummyChangeset.get(e.path), validation: e.message });
17411741
}
17421742
expect(dummyChangeset.isInvalid).toBeTruthy();
17431743
dummyChangeset.execute();
@@ -1994,7 +1994,7 @@ describe('Unit | Utility | validation changeset', () => {
19941994
try {
19951995
await dummyChangeset.validate(changes => userSchema.validate(changes));
19961996
} catch (e) {
1997-
dummyChangeset.addError(e.path, { value: e.value.age, validation: e.message });
1997+
dummyChangeset.addError(e.path, { value: dummyChangeset.get(e.path), validation: e.message });
19981998
}
19991999

20002000
expect(dummyChangeset.changes).toEqual(expectedChanges);
@@ -2405,9 +2405,11 @@ describe('Unit | Utility | validation changeset', () => {
24052405

24062406
expect(dummyChangeset.isInvalid).toEqual(true);
24072407
try {
2408-
await dummyChangeset.validate(changes => userSchema.validate(changes));
2408+
await dummyChangeset.validate(changes => {
2409+
return userSchema.validate(changes);
2410+
});
24092411
} catch (e) {
2410-
dummyChangeset.addError(e.path, { value: e.value.age, validation: e.message });
2412+
dummyChangeset.addError(e.path, { value: dummyChangeset.get(e.path), validation: e.message });
24112413
}
24122414
expect(get(dummyChangeset, 'error.name.validation')).toEqual(['cannot be J']);
24132415
expect(get(dummyChangeset, 'error.name.value')).toBe('J');

0 commit comments

Comments
 (0)