FIX open in new tab on middle clic - #164

Author: VincentD06

src/web/wizard/components/buttons/ButtonToEventDefinition.jsx

@@ -25,12 +25,16 @@ const ButtonToEventDefinition = ({target, disabled}) => {
     const intl = useIntl();
     const tooltip = intl.formatMessage({id: "wizard.tooltipEventDefinition", defaultMessage: "Edit event definition for this alert rule"});
 
-    const openEventDefinition = () => {
-        window.open(Routes.ALERTS.DEFINITIONS.edit(target),"_self");
-    }
+    const computeURl = () => {
+        let url = '';
+        if (!disabled) {
+            url = Routes.ALERTS.DEFINITIONS.edit(target);
+        }
+        return url;
+    };
 
     return (
-        <Button bsStyle="info" title={tooltip} disabled={disabled} onClick={openEventDefinition}>
+        <Button bsStyle="info" title={tooltip} disabled={disabled} href={computeURl()}>
             <FormattedMessage id="wizard.eventDefinition" defaultMessage="Event definition" />
         </Button>
     );

src/web/wizard/components/buttons/ButtonToNotification.jsx

@@ -25,12 +25,16 @@ const ButtonToNotification  = ({target, disabled}) => {
     const intl = useIntl();
     const tooltip = intl.formatMessage({id: "wizard.tooltipNotification", defaultMessage: "Edit notification for this alert rule"});
 
-    const openNotification = () => {
-        window.open(Routes.ALERTS.NOTIFICATIONS.edit(target),"_self");
-    }
+    const computeURl = () => {
+        let url = '';
+        if (!disabled) {
+            url = Routes.ALERTS.NOTIFICATIONS.edit(target);
+        }
+        return url;
+    };
 
     return (
-        <Button bsStyle="info" title={tooltip} disabled={disabled} onClick={openNotification}>
+        <Button bsStyle="info" title={tooltip} disabled={disabled} href={computeURl()}>
             <FormattedMessage id="wizard.notification" defaultMessage="Notification" />
         </Button>
     );

src/web/wizard/components/buttons/ButtonToSearch.jsx

@@ -41,13 +41,13 @@ const ButtonToSearch = ({searchQuery1, searchQuery2, stream1, stream2, disabled}
 
     const openSearchTabs = () => {
         const url1 = createUrl(searchQuery1, stream1);
-        window.open(url1, '_blank', 'noopener,noreferrer')
+        window.open(url1, '_blank', 'noopener,noreferrer');
 
         if(stream2 || searchQuery2) {
             const url2 = createUrl(searchQuery2, stream2);
             window.open(url2, '_blank', 'noopener,noreferrer');
         }
-    }
+    };
 
     return (
         <Button bsStyle="info" title={tooltip} disabled={disabled} onClick={openSearchTabs}>

src/web/wizard/components/buttons/ButtonToUpdateRule.jsx

@@ -26,14 +26,17 @@ const ButtonToUpdateRule = ({target, disabled}) => {
     const intl = useIntl();
     const tooltip = intl.formatMessage({id: "wizard.buttonInfoUpdate", defaultMessage: "Edit this alert rule"});
 
-    const openUpdateRule = () => {
-        const url = Routes.pluginRoute('WIZARD_UPDATEALERT_ALERTRULETITLE')(target.replace(/\//g, '%2F'));
-        window.open(url,"_self");
-    }
+    const computeURl = () => {
+        let url = '';
+        if (!disabled) {
+            url = Routes.pluginRoute('WIZARD_UPDATEALERT_ALERTRULETITLE')(target.replace(/\//g, '%2F'));
+        }
+        return url;
+    };
 
     return (
         <IfPermitted permissions="wizard_alerts_rules:read">
-            <Button bsStyle="info" title={tooltip} disabled={disabled} onClick={openUpdateRule}>
+            <Button bsStyle="info" title={tooltip} disabled={disabled} href={computeURl()}>
                 <FormattedMessage id="wizard.edit" defaultMessage="Edit"/>
             </Button>
         </IfPermitted>