Skip to content

Commit 3c05ccc

Browse files
authored
Fixes Git Issue 102 via commenting out line in lib/Crypt/LE.pm
[ 30/SEP/2025 AJMETZ ] - commented out line 674 ( $key->use_pkcs1_padding; ) following advice expressed in discussion of Git Issue 102 [ do-know#102 ] and feedback on an earlier pull request [ do-know#103 (review) ]. This will effectively delegate to Crypt::OpenSSL::RSA to set a default padding, and avoid the likes of errors such as: "PKCS#1 1.5 is disabled as it is known to be vulnerable to marvin attacks."
1 parent ce3560e commit 3c05ccc

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

lib/Crypt/LE.pm

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -671,7 +671,11 @@ sub _set_key {
671671
my $pem = $key->get_private_key_string;
672672
my ($n, $e) = $key->get_key_parameters;
673673
return $self->_status(INVALID_DATA, "Key modulus is divisible by a small prime and will be rejected.") if $self->_is_divisible($n);
674-
$key->use_pkcs1_padding;
674+
#$key->use_pkcs1_padding; # [ 30/SEP/2025 AJMETZ ] - commented out following advice expressed
675+
# in discussion of Git Issue 102 [ https://github.com/do-know/Crypt-LE/issues/102 ]
676+
# and feedback on an earlier pull request [ https://github.com/do-know/Crypt-LE/pull/103#pullrequestreview-3220666378 ].
677+
# This will effectively delegate to Crypt::OpenSSL::RSA to set a default padding,
678+
# and avoid the likes of errors such as: "PKCS#1 1.5 is disabled as it is known to be vulnerable to marvin attacks."
675679
$key->use_sha256_hash;
676680
$self->{key_params} = { n => $n, e => $e };
677681
$self->{key} = $key;

0 commit comments

Comments
 (0)