-
Notifications
You must be signed in to change notification settings - Fork 0
FIX remove pytest cache warning #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
| - ./data/filestore:/data/odoo/filestore | ||
| - ./data/sessions:/data/odoo/sessions | ||
| # pytest | ||
| - ./odoo/.pytest_cache:/odoo/.pytest_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to create a volume instead of a mount bind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mount bind = directory or file (?!) exists in the project directory, it's visible to the user in the file system / editor.
It should exists before runing docker compose and have the right file permissions.
Instead volume is created / managed / prunned automatically by docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then you mean in the docker file !?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use volumes to define multiple types of mounts; volume, bind, tmpfs, or npipe.
https://docs.docker.com/reference/compose-file/services/#volumes:~:text=You%20can%20use%20volume,bind
| @@ -1,5 +1,4 @@ | |||
| [pytest] | |||
| addopts = --odoo-database=dbtest | |||
| capture = no | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I added it to break things :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose you to try a fresh version of odoo pytest and see warnings on 18.0

This PR removes pytest warnings
cc @florian-dacosta @hparfr @paradoxxxzero @clementmbr @bguillot @Kev-Roche