Skip to content

Conversation

@bealdav
Copy link
Member

@bealdav bealdav commented Jul 28, 2025

@bealdav bealdav requested a review from sebastienbeau July 28, 2025 08:38
@bealdav bealdav marked this pull request as ready for review July 28, 2025 08:40
- ./data/filestore:/data/odoo/filestore
- ./data/sessions:/data/odoo/sessions
# pytest
- ./odoo/.pytest_cache:/odoo/.pytest_cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to create a volume instead of a mount bind.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mount bind = directory or file (?!) exists in the project directory, it's visible to the user in the file system / editor.
It should exists before runing docker compose and have the right file permissions.

Instead volume is created / managed / prunned automatically by docker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then you mean in the docker file !?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to create a volume instead of a mount bind.

AFAIK it's already a volume or I missed smthg !?

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use volumes to define multiple types of mounts; volume, bind, tmpfs, or npipe.
https://docs.docker.com/reference/compose-file/services/#volumes:~:text=You%20can%20use%20volume,bind

image

@@ -1,5 +1,4 @@
[pytest]
addopts = --odoo-database=dbtest
capture = no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change needed ?

Copy link
Member Author

@bealdav bealdav Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I added it to break things :-)

Copy link
Member Author

@bealdav bealdav Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose you to try a fresh version of odoo pytest and see warnings on 18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants