b (#16) Rename notification group for update activity

Author: albertoventurini

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+
+- Renamed notification group for update activity (#16)
+
 ## [0.2.0]
 
 ### Added

gradle.properties

@@ -1,4 +1,4 @@
-version=0.2.0
+version=0.2.1
 
 # Intellij SDK
 intellijSdkVersion=2022.2

graph-database-plugin/src/main/resources/META-INF/plugin.xml

@@ -183,7 +183,7 @@
         <preFormatProcessor implementation="com.albertoventurini.graphdbplugin.language.cypher.formatter.CypherPreFormatter" />
         <codeInsight.lineMarkerProvider language="Cypher" implementationClass="com.albertoventurini.graphdbplugin.jetbrains.component.linemarker.CypherLineMarkerProvider"/>
 
-        <notificationGroup id="GraphDatabaseSupportUpdateNotification"
+        <notificationGroup id="graphdbplugin.notifications.update"
                            displayType="STICKY_BALLOON" />
     </extensions>
 

platform/src/main/java/com/albertoventurini/graphdbplugin/platform/GraphBundle.java

@@ -6,7 +6,7 @@
  */
 package com.albertoventurini.graphdbplugin.platform;
 
-import com.intellij.CommonBundle;
+import com.intellij.AbstractBundle;
 import org.jetbrains.annotations.PropertyKey;
 
 import java.util.ResourceBundle;
@@ -18,12 +18,12 @@ public class GraphBundle {
     private static final ResourceBundle BUNDLE = ResourceBundle.getBundle(BUNDLE_NAME);
 
     public static String message(@PropertyKey(resourceBundle = BUNDLE_NAME) String key, Object... params) {
-        return CommonBundle.message(BUNDLE, key, params);
+        return AbstractBundle.message(BUNDLE, key, params);
     }
 
     public static String messageOrDefault(@PropertyKey(resourceBundle = BUNDLE_NAME) String key, String defaultValue,
                                           Object... params) {
-        return CommonBundle.messageOrDefault(BUNDLE, key, defaultValue, params);
+        return AbstractBundle.messageOrDefault(BUNDLE, key, defaultValue, params);
     }
 
 }

ui/jetbrains/src/main/java/com/albertoventurini/graphdbplugin/jetbrains/component/settings/SettingsComponent.java

@@ -8,14 +8,15 @@
 
 import com.intellij.openapi.application.ApplicationManager;
 
+/**
+ * This service allows persisting and reading configuration settings.
+ */
 public interface SettingsComponent {
 
     static SettingsComponent getInstance() {
         return ApplicationManager.getApplication().getService(SettingsComponent.class);
     }
 
-    String getUserId();
-
     boolean isGraphViewZoomInverted();
 
     void invertGraphViewZoom(boolean state);

ui/jetbrains/src/main/java/com/albertoventurini/graphdbplugin/jetbrains/component/settings/SettingsComponentImpl.java

@@ -8,22 +8,10 @@
 
 import com.intellij.ide.util.PropertiesComponent;
 
-import java.util.UUID;
-
 public class SettingsComponentImpl implements SettingsComponent {
 
-    private static final String USE_FILE_SPECIFIC_PARAMS_KEY = "GraphDbSupport.UseFileSpecificParams";
-    private static final String USER_ID = "GraphDbSupport.UserId";
-    private static final String KNOWN_PLUGIN_VERSION = "GraphDbSupport.KnownPluginVersion";
-    private static final String GRAPH_VIEW_INVERT_ZOOM = "GraphDbSupport.GraphViewInvertZoom";
-
-    @Override
-    public String getUserId() {
-        if (!properties().isValueSet(USER_ID)) {
-            properties().setValue(USER_ID, UUID.randomUUID().toString());
-        }
-        return properties().getValue(USER_ID);
-    }
+    private static final String KNOWN_PLUGIN_VERSION = "GraphDbPlugin.KnownPluginVersion";
+    private static final String GRAPH_VIEW_INVERT_ZOOM = "GraphDbPlugin.GraphViewInvertZoom";
 
     @Override
     public boolean isGraphViewZoomInverted() {

ui/jetbrains/src/main/java/com/albertoventurini/graphdbplugin/jetbrains/component/updater/PluginUpdateActivity.java

@@ -16,33 +16,34 @@
 import com.albertoventurini.graphdbplugin.platform.GraphConstants;
 import org.jetbrains.annotations.NotNull;
 
-import javax.swing.event.HyperlinkEvent;
+import java.util.concurrent.atomic.AtomicBoolean;
 
+/**
+ * Displays a notification when the plugin was updated to a new version.
+ */
 public class PluginUpdateActivity implements StartupActivity, DumbAware {
 
-    private static final String NOTIFICATION_ID = "GraphDatabaseSupportUpdateNotification";
-    private boolean isUpdateNotificationShown = false;
+    private final AtomicBoolean isUpdateNotificationShown = new AtomicBoolean(false);
 
     @Override
-    public void runActivity(@NotNull Project project) {
-        String currentVersion = PluginUtil.getVersion();
-        String knownVersion = SettingsComponent.getInstance().getKnownPluginVersion();
+    public void runActivity(@NotNull final Project project) {
+        final String currentVersion = PluginUtil.getVersion();
+        final String knownVersion = SettingsComponent.getInstance().getKnownPluginVersion();
 
-        boolean isUpdated = !currentVersion.equals(knownVersion);
+        final boolean isUpdated = !currentVersion.equals(knownVersion);
         if (isUpdated || GraphConstants.IS_DEVELOPMENT) {
-            if (!isUpdateNotificationShown) {
+            if (isUpdateNotificationShown.compareAndSet(false, true)) {
                 SettingsComponent.getInstance().setKnownPluginVersion(currentVersion);
                 showNotification(project, currentVersion);
-                isUpdateNotificationShown = true;
             }
         }
     }
 
-    private void showNotification(Project project, String currentVersion) {
-        NotificationGroup group = NotificationGroupManager.getInstance()
-                .getNotificationGroup("GraphDatabaseSupportUpdateNotification");
+    private void showNotification(@NotNull final Project project, String currentVersion) {
+        final NotificationGroup group = NotificationGroupManager.getInstance()
+                .getNotificationGroup("graphdbplugin.notifications.update");
 
-        Notification notification = group.createNotification(
+        final Notification notification = group.createNotification(
                 GraphBundle.message("updater.title", currentVersion),
                 GraphBundle.message("updater.notification"),
                 NotificationType.INFORMATION