Doesn't work on Angular > 1.5

[DavideViolante]

It seems to not work anymore on latest angular: https://plnkr.co/edit/tTZ4RGsRpai2BWauT6CQ?p=preview

Do you have any ideas how to make it work?

[alexcheng1982]

Just checked, it works on AngularJS 1.5.11, so may be caused by changes in 1.6.

[alexcheng1982]

This is caused by a breaking change in AngularJS 1.6 which causes dynamic created select options are ignored when reading values from the select, see this line. To make this work, ng-value needs to be added to select option element. However, the option elements are generated by select2, so it's not possible to change the markup.

So far you have to use 1.5.x.

[DavideViolante]

Do you have in plan any fix for this? Would be really appreciated.

Maybe if I look a little bit into the code I may send you a PR myself.

[alexcheng1982]

I'm sure about what's the best way to fix it yet. To fix the issue, I may need to replace select2 with the standard HTML select element, which doesn't have the built-in search functionality. Or I can fork select2 to add the attribute ng-value for AngularJS. I may go with the second way.

…

On Thu, Feb 22, 2018 at 10:09 PM, Davide Violante ***@***.***> wrote: Do you have in plan any fix for this? Would be really appreciated. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHgEKMU5ENo1CQqm8w5emcytYnd9QoSks5tXS60gaJpZM4SNhWQ> .

-- Regards Alex Cheng

[binaryhq]

any work around for angular 1.7?

[DavideViolante]

I had to upgrade to new angular so I removed this lib and used a custom solution, that I will show you here @Ningappa :

Template

    <select ng-model="ctrl.selectedTimezone"
            ng-options="timezone for timezone in ctrl.timezoneNamesWithOffset"
            ng-change="ctrl.updateProfile()">
    </select>

Ctrl

    var timezoneNames = moment.tz.names();
    function addOffsetToNames() {
      for(var i = 0; i < timezoneNames.length; i++) {
        self.timezoneNamesWithOffset.push(timezoneNames[i] + ' (GMT' + moment.tz(timezoneNames[i]).format('Z') + ')');
      }
    }

Yes, there is no search in the select, but I don't care much, they are already sorted out and easy to find.

[lazynewt]

Could really do with a solution to this..