[coro_http][feat]replace resp body int with int64 (#981)

Author: qicosmos

include/ylt/standalone/cinatra/coro_http_client.hpp

@@ -1706,12 +1706,17 @@ class coro_http_client : public std::enable_shared_from_this<coro_http_client> {
       parse_ret = -1;
     }
 #endif
-    if (parse_ret < 0) {
+    if (parse_ret < 0) [[unlikely]] {
 #ifdef INJECT_FOR_HTTP_CLIENT_TEST
       inject_response_valid = ClientInjectAction::none;
 #endif
       return std::make_error_code(std::errc::protocol_error);
     }
+    if (parser_.body_len() < 0) [[unlikely]] {
+      CINATRA_LOG_ERROR << "invalid http content length: "
+                        << parser_.body_len();
+      return std::make_error_code(std::errc::invalid_argument);
+    }
     head_buf_.consume(header_size);  // header size
     data.resp_headers = parser.get_headers();
     data.status = parser.status();

include/ylt/standalone/cinatra/http_parser.hpp

@@ -28,6 +28,21 @@ inline bool iequal0(std::string_view a, std::string_view b) {
 
 class http_parser {
  public:
+  void parse_body_len() {
+    auto header_value = this->get_header_value("content-length"sv);
+    if (header_value.empty()) {
+      body_len_ = 0;
+    }
+    else {
+      auto [ptr, ec] = std::from_chars(
+          header_value.data(), header_value.data() + header_value.size(),
+          body_len_, 10);
+      if (ec != std::errc{}) {
+        body_len_ = -1;
+      }
+    }
+  }
+
   int parse_response(const char *data, size_t size, int last_len) {
     int minor_version;
 
@@ -38,13 +53,7 @@ class http_parser {
         data, size, &minor_version, &status_, &msg, &msg_len, headers_.data(),
         &num_headers_, last_len);
     msg_ = {msg, msg_len};
-    auto header_value = this->get_header_value("content-length"sv);
-    if (header_value.empty()) {
-      body_len_ = 0;
-    }
-    else {
-      body_len_ = atoi(header_value.data());
-    }
+    parse_body_len();
     if (header_len_ < 0) [[unlikely]] {
       CINATRA_LOG_WARNING << "parse http head failed";
       if (size == CINATRA_MAX_HTTP_HEADER_FIELD_SIZE) {
@@ -92,13 +101,7 @@ class http_parser {
       body_len_ = 0;
     }
     else {
-      auto content_len = this->get_header_value("content-length"sv);
-      if (content_len.empty()) {
-        body_len_ = 0;
-      }
-      else {
-        body_len_ = atoi(content_len.data());
-      }
+      parse_body_len();
     }
 
     full_url_ = url_;
@@ -204,9 +207,9 @@ class http_parser {
 
   int header_len() const { return header_len_; }
 
-  int body_len() const { return body_len_; }
+  int64_t body_len() const { return body_len_; }
 
-  int total_len() const { return header_len_ + body_len_; }
+  int64_t total_len() const { return header_len_ + body_len_; }
 
   bool is_location() {
     auto location = this->get_header_value("Location"sv);
@@ -260,7 +263,7 @@ class http_parser {
   std::string_view msg_;
   size_t num_headers_ = 0;
   int header_len_ = 0;
-  int body_len_ = 0;
+  int64_t body_len_ = 0;
   bool has_connection_{};
   bool has_close_{};
   bool has_upgrade_{};

src/coro_http/tests/test_cinatra.cpp

@@ -943,6 +943,21 @@ TEST_CASE("test request with out buffer") {
   }
 }
 
+TEST_CASE("test response body greater than 2GB") {
+  coro_http_server server(1, 8090);
+  std::string resp_str;
+  size_t large_size = 1024 * 1024 * 1024 + 10;
+  detail::resize(resp_str, large_size);
+  server.set_http_handler<GET>(
+      "/test", [&](coro_http_request &req, coro_http_response &resp) {
+        resp.set_status_and_content(status_type::ok, std::move(resp_str));
+      });
+  server.async_start();
+  coro_http_client client;
+  auto result = client.get("http://127.0.0.1:8090/test");
+  CHECK(result.resp_body.length() == large_size);
+}
+
 TEST_CASE("test pass path not entire uri") {
   coro_http_client client{};
   client.set_conn_timeout(2s);