feat: add the transfer buttons to top navigation #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorezende
approved these changes
Sep 20, 2024
| @@ -4,8 +4,8 @@ import { defaultAccountAtom, disconnectAccountAtom } from "atoms/accounts"; | |||
| import clsx from "clsx"; | |||
| import { useAtomValue } from "jotai"; | |||
| import { useLocation, useNavigate } from "react-router-dom"; | |||
| import { DisconnectAccountIcon } from "./DisconnectAccountIcon"; | |||
| import { SwitchAccountIcon } from "./SwitchAccountIcon"; | |||
| import { DisconnectAccountIcon } from "../Icons/DisconnectAccountIcon"; | |||
There was a problem hiding this comment.
Once they're not in the same folder, can we use App/Icons/DisconnectAccountIcon instead?
There was a problem hiding this comment.
oh, good observation! actually, I'll move it to the same folder as I saw this pattern on other features as well :)
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the transfer buttons to top navigation
And improve the responsiveness to the
<AppHeader>that contains the burger, the logo, the new buttons and so on