Skip to content

Commit 85a49da

Browse files
committed
address comments
1 parent e9d8f7d commit 85a49da

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sdks/python/apache_beam/yaml/examples/testing/examples_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -681,8 +681,8 @@ def _pubsub_io_read_test_preprocessor(
681681
def _jdbc_io_read_test_preprocessor(
682682
test_spec: dict, expected: List[str], env: TestEnvironment):
683683
"""
684-
Preprocessor for tests that involve reading from SqlServer.
685-
url syntax: 'jdbc:mysql://<host>:<port>/<database>'
684+
Preprocessor for tests that involve reading from generic Jdbc.
685+
url syntax: 'jdbc:<database-type>://<host>:<port>/<database>'
686686
"""
687687
return _db_io_read_test_processor(
688688
test_spec, lambda url: url.split('/')[-1], 'Jdbc')

sdks/python/apache_beam/yaml/examples/transforms/blueprint/postgres_to_bigquery.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ pipeline:
2828
config:
2929
url: "jdbc:postgresql://localhost:12345/shipment?user=user&password=postgres123"
3030
query: "SELECT * FROM shipments"
31-
driver_class_name: "com.microsoft.sqlserver.jdbc.SQLServerDriver"
31+
driver_class_name: "org.postgresql.Driver"
3232
# Step 2: Write records out to BigQuery
3333
- type: WriteToBigQuery
3434
name: WriteShipments

0 commit comments

Comments
 (0)