From 4386f5f63189da4b054a2da6a0444142cfed58d5 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Sun, 10 Nov 2024 19:23:37 -0500 Subject: [PATCH 1/5] Allowlist org.glassfish:javax.json --- .../plugins/dependency/analyze/AbstractAnalyzeMojo.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java b/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java index ebff3dcea4..31477e8a44 100644 --- a/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java +++ b/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java @@ -120,7 +120,7 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo { private boolean ignoreAllNonTestScoped; /** - * Output the xml for the missing dependencies (used but not declared). + * Output the XML for the missing dependencies (used but not declared). * * @since 2.0-alpha-5 */ @@ -231,7 +231,7 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo { * * @since 2.10 */ - @Parameter(defaultValue = "org.slf4j:slf4j-simple::") + @Parameter(defaultValue = "org.slf4j:slf4j-simple::,org.glassfish:javax.json::") private String[] ignoredUnusedDeclaredDependencies; /** @@ -251,7 +251,7 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo { * * @since 3.3.0 */ - @Parameter(defaultValue = "org.slf4j:slf4j-simple::") + @Parameter(defaultValue = "org.slf4j:slf4j-simple::,org.glassfish:javax.json::") private String[] ignoredNonTestScopedDependencies; /** From 63999bc645547cfeaf5cc536e1e2a4fe6bd5261e Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Sun, 10 Nov 2024 19:30:44 -0500 Subject: [PATCH 2/5] integration test --- src/it/projects/analyze/pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/it/projects/analyze/pom.xml b/src/it/projects/analyze/pom.xml index e3072ae884..afc9628509 100644 --- a/src/it/projects/analyze/pom.xml +++ b/src/it/projects/analyze/pom.xml @@ -58,6 +58,12 @@ slf4j-simple 2.0.16 + + + org.glassfish + javax.json + 1.1.4 + From d54403ac33f87fc2fa833a8937aeb4c7cc1e61e1 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Mon, 7 Jul 2025 08:49:34 -0400 Subject: [PATCH 3/5] comments --- src/it/projects/analyze/pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/it/projects/analyze/pom.xml b/src/it/projects/analyze/pom.xml index afc9628509..e3a134aea0 100644 --- a/src/it/projects/analyze/pom.xml +++ b/src/it/projects/analyze/pom.xml @@ -52,13 +52,13 @@ maven-model 2.0.6 - + org.slf4j slf4j-simple 2.0.16 - + org.glassfish javax.json From fdc49ed516788248838fb189884678a183bbcbeb Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Thu, 17 Jul 2025 06:52:45 -0400 Subject: [PATCH 4/5] spotless --- .../maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java b/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java index 0083be856e..0d82a84395 100644 --- a/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java +++ b/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java @@ -223,7 +223,8 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo { @Parameter private String[] ignoredUnusedDeclaredDependencies = new String[0]; - private String[] unconditionallyIgnoredDeclaredDependencies = {"org.slf4j:slf4j-simple::,org.glassfish:javax.json::"}; + private String[] unconditionallyIgnoredDeclaredDependencies = {"org.slf4j:slf4j-simple::,org.glassfish:javax.json::" + }; /** * List of dependencies that are ignored if they are in not test scope but are only used in test classes. From 63bb4717a63f5e52e14ac8f0e01aa2048c2ab665 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Thu, 17 Jul 2025 07:11:09 -0400 Subject: [PATCH 5/5] fix it --- src/it/projects/analyze/verify.groovy | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/it/projects/analyze/verify.groovy b/src/it/projects/analyze/verify.groovy index 4b430120a0..68af167b89 100644 --- a/src/it/projects/analyze/verify.groovy +++ b/src/it/projects/analyze/verify.groovy @@ -36,8 +36,5 @@ assert buildLog.contains( '[WARNING] org.apache.maven:maven-repository-metada assert buildLog.contains( '[WARNING] class org.apache.maven.artifact.repository.metadata.Metadata') assert buildLog.contains( '[WARNING] Unused declared dependencies found:') assert buildLog.contains( '[WARNING] org.apache.maven:maven-project:jar:2.0.6:compile') -assert buildLog.contains( '[INFO] Ignored unused declared dependencies:') -assert buildLog.contains( '[INFO] org.slf4j:slf4j-simple:jar:2.0.16:compile') -assert !buildLog.contains( '[WARNING] org.slf4j:slf4j-simple:jar:2.0.16:compile') return true