feat: add pre-commit framework

Author: jbampton

.markdownlint.yml

@@ -0,0 +1,29 @@
+MD001: false
+MD002: false
+MD003: false
+MD004: false
+MD005: false
+MD006: false
+MD007: false
+MD009: false
+MD010: false
+MD012: false
+MD013: false
+MD014: false
+MD019: false
+MD022: false
+MD023: false
+MD024: false
+MD026: false
+MD029: false
+MD030: false
+MD031: false
+MD032: false
+MD033: false
+MD034: false
+MD037: false
+MD040: false
+MD041: false
+MD042: false
+MD045: false
+MD046: false

.pre-commit-config.yaml

@@ -0,0 +1,79 @@
+---
+default_stages: [commit, push]
+default_language_version:
+  # force all unspecified Python hooks to run python3
+  python: python3
+minimum_pre_commit_version: "1.20.0"
+repos:
+  - repo: meta
+    hooks:
+      - id: identity
+      - id: check-hooks-apply
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v3.4.0
+    hooks:
+      - id: check-added-large-files
+      # - id: check-ast
+      # - id: check-builtin-literals
+      - id: check-case-conflict
+      - id: check-docstring-first
+      - id: check-executables-have-shebangs
+    #  - id: check-json
+      - id: check-merge-conflict
+      - id: check-xml
+    #  - id: check-yaml
+    #  - id: debug-statements
+    #  - id: end-of-file-fixer
+      - id: fix-byte-order-marker
+      - id: mixed-line-ending
+    #  - id: pretty-format-json
+    #  - id: trailing-whitespace
+  # - repo: https://github.com/psf/black
+  #  rev: 20.8b1
+  #  hooks:
+  #    - id: black
+  #      name: Run black on Python files
+  # - repo: https://github.com/asottile/dead
+  #  rev: v1.4.0
+  #  hooks:
+  #    - id: dead
+  #      name: Dead simple python dead code detection
+  # - repo: https://github.com/asottile/reorder_python_imports
+  #  rev: v2.4.0
+  #  hooks:
+  #    - id: reorder-python-imports
+  # - repo: https://github.com/jumanjihouse/pre-commit-hooks
+  #  rev: 2.1.5
+  #  hooks:
+  #    - id: shellcheck
+  # - repo: git://github.com/Lucas-C/pre-commit-hooks
+  #  rev: v1.1.9
+  #  hooks:
+  #    - id: forbid-tabs
+  #    - id: remove-tabs
+  - repo: https://github.com/pre-commit/pygrep-hooks
+    rev: v1.8.0
+    hooks:
+      - id: python-check-mock-methods
+      - id: python-no-eval
+      - id: python-no-log-warn
+  - repo: https://github.com/igorshubovych/markdownlint-cli
+    rev: v0.27.1
+    hooks:
+      - id: markdownlint
+        name: Run markdownlint
+  # - repo: https://github.com/adrienverge/yamllint
+  #  rev: v1.26.0
+  #  hooks:
+  #    - id: yamllint
+  #      name: Check YAML files with yamllint
+  #      entry: yamllint --strict .
+  #      types: [yaml]
+  # - repo: https://github.com/PyCQA/bandit
+  #  rev: 1.7.0
+  #  hooks:
+  #    - id: bandit
+  # - repo: https://gitlab.com/pycqa/flake8
+  #  rev: 3.8.4
+  #  hooks:
+  #    - id: flake8

.yamllint

@@ -0,0 +1,12 @@
+---
+
+extends: default
+
+rules:
+  colons: disable
+  comments: disable
+  comments-indentation: disable
+  document-start: disable
+  indentation: disable
+  line-length: disable
+  truthy: disable

CONTRIBUTING.md

@@ -69,3 +69,22 @@ code base. Some basic rules include:
  - all files must have the Apache license in the header.
  - all PRs must have passing builds for all operating systems.
  - the code is correctly formatted as defined in the [Scalariform plugin properties](tools/eclipse/scala.properties). If you use IntelliJ for development this [page](https://plugins.jetbrains.com/plugin/7480-scalariform) describes the setup and configuration of the plugin.
+
+#### Pre-commit
+
+A framework for managing and maintaining multi-language pre-commit hooks.
+Pre-commit can be [installed](https://pre-commit.com/#installation) with `pip`, `curl`, `brew` or `conda`.
+
+You need to first install pre-commit and then install the pre-commit hooks with `pre-commit install`.
+Now pre-commit will run automatically on git commit!
+
+It's usually a good idea to run the hooks against all the files when adding new hooks (usually pre-commit will only run on the changed files during git hooks).
+Use `pre-commit run --all-files` to check all files.
+
+You can update your hooks to the latest version automatically by running `pre-commit autoupdate`.
+
+##### Hooks
+
+The hooks run:
+
+- [markdownlint-cli](https://github.com/igorshubovych/markdownlint-cli)

ansible/roles/controller/tasks/lean.yml

@@ -51,4 +51,3 @@
     userns_mode: "host"
     pid_mode: "host"
     privileged: "yes"
-

ansible/roles/couchdb/tasks/deploy.yml

@@ -183,4 +183,3 @@
     password: "{{ db.credentials.admin.pass }}"
     force_basic_auth: yes
   when: (inventory_hostname == coordinator) and (db.instances|int >= 2) and (cluster_state.json.state != "cluster_finished")
-

core/monitoring/user-events/compose/prometheus/prometheus.yml

@@ -27,4 +27,3 @@ scrape_configs:
   - job_name: 'openwhisk-metrics'
     static_configs:
       - targets: ['user-events:9095']
-

tests/dat/actions/unicode.tests/src/dotnet2.2/openwhisk-unicodetests-dotnet.sln

@@ -1,4 +1,4 @@
-Microsoft Visual Studio Solution File, Format Version 12.00
+Microsoft Visual Studio Solution File, Format Version 12.00
 
 #
 # Licensed to the Apache Software Foundation (ASF) under one or more