From 801eed89a49abad25f28580f7015b1f02159b66a Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Tue, 30 Sep 2025 00:24:47 +0530 Subject: [PATCH 01/13] move filters button to right side and fix search placeholder --- .../layout/responsiveContainerHeader.svelte | 4 +- .../messaging/providers/+page.svelte | 42 +++++++++---------- 2 files changed, 22 insertions(+), 24 deletions(-) diff --git a/src/lib/layout/responsiveContainerHeader.svelte b/src/lib/layout/responsiveContainerHeader.svelte index 0f5358a029..29eed0f56c 100644 --- a/src/lib/layout/responsiveContainerHeader.svelte +++ b/src/lib/layout/responsiveContainerHeader.svelte @@ -106,11 +106,11 @@ {#if hasSearch} {/if} + + {#if hasFilters && $columns?.length} {/if} - - {#if hasDisplaySettings} {/if} diff --git a/src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte b/src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte index 85b132238d..8086a93bda 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte @@ -3,19 +3,17 @@ import { Button } from '$lib/elements/forms'; import { EmptySearch, - SearchQuery, PaginationWithLimit, - ViewSelector, EmptyFilter } from '$lib/components'; - import { Container } from '$lib/layout'; + import { Container, ResponsiveContainerHeader } from '$lib/layout'; import { columns } from './store'; - import { Filters, hasPageQueries } from '$lib/components/filters'; + import { hasPageQueries } from '$lib/components/filters'; import CreateProviderDropdown from './createProviderDropdown.svelte'; import Table from './table.svelte'; import { base } from '$app/paths'; import { canWriteProviders } from '$lib/stores/roles'; - import { Card, Layout, Empty, Icon } from '@appwrite.io/pink-svelte'; + import { Card, Empty, Icon } from '@appwrite.io/pink-svelte'; import { View } from '$lib/helpers/load'; import { IconPlus } from '@appwrite.io/pink-icons-svelte'; @@ -23,23 +21,23 @@ - - - - - - - - {#if $canWriteProviders} - - - - {/if} - - + + {#if $canWriteProviders} + + + + {/if} + {#if data.providers.total} From b8a472f3c203686d5e43efa7e8215bd36e8db614 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Tue, 30 Sep 2025 15:17:56 +0530 Subject: [PATCH 02/13] lint issue --- .../messaging/providers/+page.svelte | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte b/src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte index 8086a93bda..e1e5d1c4f8 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte @@ -1,11 +1,7 @@ -
- - {#if $$slots.subtitle} -

- -

- {/if} -
+ {#if $$slots.title || $$slots.subtitle} +
+ + {#if $$slots.subtitle} +

+ +

+ {/if} +
+ {/if}
From 448ab6651729431aedc6e1e145c594971aa507cf Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Tue, 30 Sep 2025 15:44:20 +0530 Subject: [PATCH 05/13] Remove unnecessary extra spacing here --- src/lib/layout/wizardStep.svelte | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/lib/layout/wizardStep.svelte b/src/lib/layout/wizardStep.svelte index 7ab7e88945..591fb62e8e 100644 --- a/src/lib/layout/wizardStep.svelte +++ b/src/lib/layout/wizardStep.svelte @@ -22,8 +22,13 @@ {#if $$slots.title || $$slots.subtitle} -
- +
+ {#if $$slots.title} + + {/if} {#if $$slots.subtitle}

@@ -44,4 +49,8 @@ padding-block-end: 0; border-block-end: none; } + + .only-subtitle { + margin-block-end: 0.5rem; + } From dbee85e982e43d319e33f4b64b5f32a53a59d625 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Tue, 30 Sep 2025 15:50:25 +0530 Subject: [PATCH 06/13] Read the guide in the docs should open a new tab --- .../messaging/providers/create.svelte | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/providers/create.svelte b/src/routes/(console)/project-[region]-[project]/messaging/providers/create.svelte index a26def4fd9..96da3d9e9e 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/providers/create.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/providers/create.svelte @@ -227,7 +227,9 @@ hasDivider href={`https://appwrite.io/docs/products/messaging/${$provider}`} title="Read the guide in the docs" - icon={IconBookOpen} /> + icon={IconBookOpen} + target="_blank" + rel="noreferrer" /> { $newMemberModal = true; From 13c68f00e830bd6b1ae040bebaf2bcf68027283a Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Tue, 30 Sep 2025 15:55:35 +0530 Subject: [PATCH 07/13] Add wizard footer with Create button (Currently we have a divider and a button in the wrong place) --- .../messaging/providers/create.svelte | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/providers/create.svelte b/src/routes/(console)/project-[region]-[project]/messaging/providers/create.svelte index 96da3d9e9e..a2b6160d58 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/providers/create.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/providers/create.svelte @@ -21,6 +21,8 @@ import { providers } from './store'; import CreateMember from '$routes/(console)/organization-[organization]/createMember.svelte'; + let formRef: any; + async function create() { try { let response: Models.Provider; @@ -185,7 +187,7 @@ -
+

@@ -193,9 +195,6 @@
- - - @@ -243,4 +242,9 @@ {#if $newMemberModal} {/if} + + + + + From a41cfd895834a72b7aa27fab57e60580ed4be12e Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Tue, 30 Sep 2025 19:30:57 +0530 Subject: [PATCH 08/13] fix subscribers screen --- .../messaging/topics/topic-[topic]/+page.svelte | 6 ++---- .../messaging/userTargetsModal.svelte | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte b/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte index 338601be6d..f7aac1d13c 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/topics/topic-[topic]/+page.svelte @@ -71,9 +71,7 @@ await Promise.all(promises); addNotification({ type: 'success', - message: `Added ${targetIds.length} subscriber${ - targetIds.length > 1 ? 's' : '' - } to topic` + message: `${targetIds.length} subscriber${targetIds.length !== 1 ? 's' : ''} have been added` }); trackEvent(Submit.MessagingTopicSubscriberAdd); await invalidate(Dependencies.MESSAGING_TOPIC_SUBSCRIBERS); @@ -146,7 +144,7 @@ href="https://appwrite.io/docs/products/messaging/topics#subscribe-targets-to-topics" target="_blank" rel="noopener noreferrer" - class="link">Learn more about subscribersLearn more.

diff --git a/src/routes/(console)/project-[region]-[project]/messaging/userTargetsModal.svelte b/src/routes/(console)/project-[region]-[project]/messaging/userTargetsModal.svelte index 8478762f1c..179c869d9a 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/userTargetsModal.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/userTargetsModal.svelte @@ -216,7 +216,7 @@ Users selected - + From 8a9efc1457ebf094082307c4b49876f1d0d0db92 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Tue, 30 Sep 2025 19:37:29 +0530 Subject: [PATCH 09/13] fixed the width of provider popup --- .../messaging/providers/popoverContent.svelte | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/messaging/providers/popoverContent.svelte b/src/routes/(console)/project-[region]-[project]/messaging/providers/popoverContent.svelte index 7b9a1e7239..335b3bc281 100644 --- a/src/routes/(console)/project-[region]-[project]/messaging/providers/popoverContent.svelte +++ b/src/routes/(console)/project-[region]-[project]/messaging/providers/popoverContent.svelte @@ -1,21 +1,28 @@ -
+
{#each lines as line}

{@html line}

{/each} {#if image} - + + + {/if}