Skip to content

Commit 8b9e364

Browse files
mialeskamialeska
authored
Migrate to Java 11 (#138) +semver: feature
* [Breaking] Migrate to Java 11 * update pipelines and README.md
1 parent aa6e2ba commit 8b9e364

File tree

7 files changed

+27
-20
lines changed

7 files changed

+27
-20
lines changed

‎.github/workflows/release-maven-central.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Step 2 - Set up Maven Central Repository
1919
uses: actions/setup-java@v3
2020
with:
21-
java-version: "8"
21+
java-version: "11"
2222
distribution: "adopt"
2323
server-id: ossrh
2424
server-username: MVN_CENTRAL_USERNAME

‎README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ Most of performed methods are logged using LOG4J, so you can easily see a histor
1212

1313
We use interfaces where is possible, so you can implement your own version of target interface with no need to rewrite other classes.
1414

15+
16+
> ### Breaking news!
17+
> Starting from v4.4.0 onwards, this package requires Java 11 or higher, as Selenium has stopped support of Java 8.
18+
> The last version available for Java 8 is [v4.3.3](https://github.com/aquality-automation/aquality-selenium-java/releases/tag/v4.3.3)
19+
1520
### Quick start
1621
To start the project using aquality.selenium framework, you can [download our template BDD project by this link.](https://github.com/aquality-automation/aquality-selenium-java-template)
1722

‎azure-pipelines.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
mavenPomFile: 'pom.xml'
2626
mavenOptions: '-Xmx3072m'
2727
javaHomeOption: 'JDKVersion'
28-
jdkVersionOption: '1.8'
28+
jdkVersionOption: '11'
2929
jdkArchitectureOption: 'x64'
3030
publishJUnitResults: true
3131
testResultsFiles: '**/surefire-reports/TEST-*.xml'
@@ -55,7 +55,7 @@ jobs:
5555
mavenPomFile: 'pom.xml'
5656
mavenOptions: '-Xmx3072m'
5757
javaHomeOption: 'JDKVersion'
58-
jdkVersionOption: '1.8'
58+
jdkVersionOption: '11'
5959
jdkArchitectureOption: 'x64'
6060
publishJUnitResults: true
6161
testResultsFiles: '**/surefire-reports/TEST-*.xml'

‎pom.xml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,12 @@
8282
<dependency>
8383
<groupId>com.github.aquality-automation</groupId>
8484
<artifactId>aquality-selenium-core</artifactId>
85-
<version>3.1.2</version>
85+
<version>4.0.0</version>
8686
</dependency>
8787
<dependency>
8888
<groupId>org.apache.commons</groupId>
8989
<artifactId>commons-lang3</artifactId>
90-
<version>3.13.0</version>
90+
<version>3.14.0</version>
9191
</dependency>
9292
<dependency>
9393
<groupId>com.fasterxml.jackson.core</groupId>
@@ -97,7 +97,7 @@
9797
<dependency>
9898
<groupId>org.slf4j</groupId>
9999
<artifactId>slf4j-simple</artifactId>
100-
<version>2.0.10</version>
100+
<version>2.0.12</version>
101101
<scope>test</scope>
102102
</dependency>
103103
<dependency>
@@ -109,7 +109,7 @@
109109
<dependency>
110110
<groupId>org.testng</groupId>
111111
<artifactId>testng</artifactId>
112-
<version>7.5.1</version>
112+
<version>7.9.0</version>
113113
<scope>test</scope>
114114
</dependency>
115115
</dependencies>
@@ -119,16 +119,16 @@
119119
<plugin>
120120
<groupId>org.apache.maven.plugins</groupId>
121121
<artifactId>maven-compiler-plugin</artifactId>
122-
<version>3.1</version>
122+
<version>3.12.1</version>
123123
<configuration>
124-
<source>1.8</source>
125-
<target>1.8</target>
124+
<source>11</source>
125+
<target>11</target>
126126
</configuration>
127127
</plugin>
128128
<plugin>
129129
<groupId>org.jacoco</groupId>
130130
<artifactId>jacoco-maven-plugin</artifactId>
131-
<version>0.8.4</version>
131+
<version>0.8.11</version>
132132
<executions>
133133
<execution>
134134
<id>pre-unit-test</id>
@@ -156,7 +156,7 @@
156156
<plugin>
157157
<groupId>org.apache.maven.plugins</groupId>
158158
<artifactId>maven-surefire-plugin</artifactId>
159-
<version>2.20</version>
159+
<version>3.2.5</version>
160160
<configuration>
161161
<argLine>${surefireArgLine} -Dfile.encoding=UTF-8</argLine>
162162
<reuseForks>false</reuseForks>
@@ -185,6 +185,7 @@
185185
<plugin>
186186
<groupId>org.apache.maven.plugins</groupId>
187187
<artifactId>maven-source-plugin</artifactId>
188+
<version>3.3.0</version>
188189
<executions>
189190
<execution>
190191
<id>attach-sources</id>
@@ -197,8 +198,9 @@
197198
<plugin>
198199
<groupId>org.apache.maven.plugins</groupId>
199200
<artifactId>maven-javadoc-plugin</artifactId>
201+
<version>3.6.3</version>
200202
<configuration>
201-
<source>8</source>
203+
<source>11</source>
202204
</configuration>
203205
<executions>
204206
<execution>
@@ -212,7 +214,7 @@
212214
<plugin>
213215
<groupId>org.apache.maven.plugins</groupId>
214216
<artifactId>maven-gpg-plugin</artifactId>
215-
<version>1.6</version>
217+
<version>3.1.0</version>
216218
<executions>
217219
<execution>
218220
<id>sign-artifacts</id>
@@ -232,7 +234,7 @@
232234
<plugin>
233235
<groupId>org.sonatype.plugins</groupId>
234236
<artifactId>nexus-staging-maven-plugin</artifactId>
235-
<version>1.6.8</version>
237+
<version>1.6.13</version>
236238
<extensions>true</extensions>
237239
<configuration>
238240
<serverId>ossrh</serverId>

‎src/test/java/tests/usecases/devtools/DeviceEmulationTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import aquality.selenium.browser.AqualityServices;
44
import aquality.selenium.browser.devtools.EmulationHandling;
55
import com.google.common.collect.ImmutableMap;
6-
import org.openqa.selenium.devtools.v117.emulation.Emulation;
7-
import org.openqa.selenium.devtools.v117.emulation.model.DisplayFeature;
6+
import org.openqa.selenium.devtools.v122.emulation.Emulation;
7+
import org.openqa.selenium.devtools.v122.emulation.model.DisplayFeature;
88
import org.testng.Assert;
99
import org.testng.annotations.BeforeMethod;
1010
import org.testng.annotations.Test;
@@ -44,7 +44,7 @@ public void setAndClearDeviceMetricsOverrideWithVersionSpecificParametersTest()
4444
AqualityServices.getBrowser().devTools().sendCommand(Emulation.setDeviceMetricsOverride(
4545
WIDTH, HEIGHT, SCALE_FACTOR, IS_MOBILE, Optional.empty(), Optional.empty(), Optional.empty(),
4646
Optional.empty(), Optional.empty(), Optional.empty(), Optional.empty(), Optional.empty(),
47-
Optional.of(DISPLAY_FEATURE)
47+
Optional.of(DISPLAY_FEATURE), Optional.empty()
4848
));
4949
AqualityServices.getLogger().info("success");
5050
});

‎src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import aquality.selenium.browser.AqualityServices;
44
import org.openqa.selenium.TimeoutException;
5-
import org.openqa.selenium.devtools.v117.network.model.ConnectionType;
5+
import org.openqa.selenium.devtools.v122.network.model.ConnectionType;
66
import org.testng.Assert;
77
import org.testng.annotations.Test;
88
import tests.BaseTest;

‎src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import manytools.BrowserLanguageForm;
99
import manytools.UserAgentForm;
1010
import org.openqa.selenium.devtools.idealized.Network;
11-
import org.openqa.selenium.devtools.v117.emulation.Emulation;
11+
import org.openqa.selenium.devtools.v122.emulation.Emulation;
1212
import org.testng.Assert;
1313
import org.testng.annotations.BeforeMethod;
1414
import org.testng.annotations.Test;

0 commit comments

Comments
 (0)