Skip to content

Commit e74b985

Browse files
author
mpv1989
committed
Fix user auth tests
1 parent 16462a1 commit e74b985

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

src/test/java/com/arangodb/UserAuthTest.java

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import java.util.Collection;
3434

3535
import org.junit.AfterClass;
36-
import org.junit.Ignore;
3736
import org.junit.Test;
3837
import org.junit.runner.RunWith;
3938
import org.junit.runners.Parameterized;
@@ -54,7 +53,6 @@
5453
*
5554
*/
5655
@RunWith(Parameterized.class)
57-
@Ignore
5856
public class UserAuthTest {
5957

6058
private static final String DB_NAME = "AuthUnitTestDB";
@@ -465,7 +463,8 @@ public void createCollection() {
465463
public void dropCollection() {
466464
try {
467465
arangoDBRoot.db(DB_NAME).createCollection(COLLECTION_NAME_NEW);
468-
if (Permissions.RW.equals(param.dbPermission)) {
466+
arangoDBRoot.db(DB_NAME).collection(COLLECTION_NAME_NEW).grantAccess(USER_NAME, param.colPermission);
467+
if (Permissions.RW.equals(param.dbPermission) && Permissions.RW.equals(param.colPermission)) {
469468
try {
470469
arangoDB.db(DB_NAME).collection(COLLECTION_NAME_NEW).drop();
471470
} catch (final ArangoDBException e) {
@@ -495,8 +494,8 @@ public void dropCollection() {
495494

496495
@Test
497496
public void seeCollection() {
498-
if (Permissions.RW.equals(param.dbPermission) || (Permissions.RO.equals(param.dbPermission)
499-
&& (Permissions.RW.equals(param.colPermission) || Permissions.RO.equals(param.colPermission)))) {
497+
if ((Permissions.RW.equals(param.dbPermission) || Permissions.RO.equals(param.dbPermission))
498+
&& (Permissions.RW.equals(param.colPermission) || Permissions.RO.equals(param.colPermission))) {
500499
try {
501500
final Collection<CollectionEntity> collections = arangoDB.db(DB_NAME).getCollections();
502501
boolean found = false;
@@ -525,8 +524,8 @@ public void seeCollection() {
525524

526525
@Test
527526
public void readCollectionInfo() {
528-
if (Permissions.RW.equals(param.dbPermission) || (Permissions.RO.equals(param.dbPermission)
529-
&& (Permissions.RW.equals(param.colPermission) || Permissions.RO.equals(param.colPermission)))) {
527+
if ((Permissions.RW.equals(param.dbPermission) || Permissions.RO.equals(param.dbPermission))
528+
&& (Permissions.RW.equals(param.colPermission) || Permissions.RO.equals(param.colPermission))) {
530529
try {
531530
assertThat(details, arangoDB.db(DB_NAME).collection(COLLECTION_NAME).getInfo(), is(notNullValue()));
532531
} catch (final ArangoDBException e) {
@@ -543,8 +542,8 @@ public void readCollectionInfo() {
543542

544543
@Test
545544
public void readCollectionProperties() {
546-
if (Permissions.RW.equals(param.dbPermission) || (Permissions.RO.equals(param.dbPermission)
547-
&& (Permissions.RW.equals(param.colPermission) || Permissions.RO.equals(param.colPermission)))) {
545+
if ((Permissions.RW.equals(param.dbPermission) || Permissions.RO.equals(param.dbPermission))
546+
&& (Permissions.RW.equals(param.colPermission) || Permissions.RO.equals(param.colPermission))) {
548547
try {
549548
assertThat(details, arangoDB.db(DB_NAME).collection(COLLECTION_NAME).getProperties(),
550549
is(notNullValue()));
@@ -562,7 +561,7 @@ public void readCollectionProperties() {
562561

563562
@Test
564563
public void writeCollectionProperties() {
565-
if (Permissions.RW.equals(param.dbPermission)) {
564+
if (Permissions.RW.equals(param.dbPermission) && Permissions.RW.equals(param.colPermission)) {
566565
try {
567566
assertThat(details, arangoDB.db(DB_NAME).collection(COLLECTION_NAME)
568567
.changeProperties(new CollectionPropertiesOptions().waitForSync(true)),
@@ -586,8 +585,8 @@ public void writeCollectionProperties() {
586585

587586
@Test
588587
public void readCollectionIndexes() {
589-
if ((Permissions.RW.equals(param.dbPermission) || (Permissions.RO.equals(param.dbPermission)
590-
&& (Permissions.RW.equals(param.colPermission) || Permissions.RO.equals(param.colPermission))))) {
588+
if ((Permissions.RW.equals(param.dbPermission) || Permissions.RO.equals(param.dbPermission))
589+
&& (Permissions.RW.equals(param.colPermission) || Permissions.RO.equals(param.colPermission))) {
591590
try {
592591
assertThat(details, arangoDB.db(DB_NAME).collection(COLLECTION_NAME).getIndexes(), is(notNullValue()));
593592
} catch (final ArangoDBException e) {
@@ -606,7 +605,7 @@ public void readCollectionIndexes() {
606605
public void createCollectionIndex() {
607606
String id = null;
608607
try {
609-
if (Permissions.RW.equals(param.dbPermission)) {
608+
if (Permissions.RW.equals(param.dbPermission) && Permissions.RW.equals(param.colPermission)) {
610609
try {
611610
final IndexEntity createHashIndex = arangoDB.db(DB_NAME).collection(COLLECTION_NAME)
612611
.createHashIndex(Arrays.asList("a"), new HashIndexOptions());
@@ -638,7 +637,7 @@ public void dropCollectionIndex() {
638637
final String id = arangoDBRoot.db(DB_NAME).collection(COLLECTION_NAME)
639638
.createHashIndex(Arrays.asList("a"), new HashIndexOptions()).getId();
640639
try {
641-
if (Permissions.RW.equals(param.dbPermission)) {
640+
if (Permissions.RW.equals(param.dbPermission) && Permissions.RW.equals(param.colPermission)) {
642641
try {
643642
arangoDB.db(DB_NAME).collection(COLLECTION_NAME).deleteIndex(id);
644643
} catch (final ArangoDBException e) {

0 commit comments

Comments
 (0)