UNOR4 OTA: add missing return value

pennam · pennam · commit 7623846b4398 · 2025-06-06T10:16:00.000+02:00
diff --git a/src/ota/implementation/OTAUnoR4.cpp b/src/ota/implementation/OTAUnoR4.cpp
@@ -98,10 +98,13 @@ OTACloudProcessInterface::State UNOR4OTACloudProcess::flashOTA() {
   }
 
   /* Flash new firmware */
-  if ((ota_err = ota.update(UPDATE_FILE_NAME)) != OTAUpdate::OTA_ERROR_NONE) { // This reboots the MCU
+  if ((ota_err = ota.update(UPDATE_FILE_NAME)) != OTAUpdate::OTA_ERROR_NONE) {
     DEBUG_VERBOSE("OTAUpdate::update() failed with %d", ota_err);
     return convertUnor4ErrorToState(ota_err);
   }
+
+  /* This is never called because ota.uptade reboots the microcontroller */
+  return Resume;
 }
 
 OTACloudProcessInterface::State UNOR4OTACloudProcess::reboot() {

Original file line number	Diff line number	Diff line change
`@@ -98,10 +98,13 @@ OTACloudProcessInterface::State UNOR4OTACloudProcess::flashOTA() {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`/* Flash new firmware */`
`101`		`- if ((ota_err = ota.update(UPDATE_FILE_NAME)) != OTAUpdate::OTA_ERROR_NONE) { // This reboots the MCU`
	`101`	`+ if ((ota_err = ota.update(UPDATE_FILE_NAME)) != OTAUpdate::OTA_ERROR_NONE) {`
`102`	`102`	`DEBUG_VERBOSE("OTAUpdate::update() failed with %d", ota_err);`
`103`	`103`	`return convertUnor4ErrorToState(ota_err);`
`104`	`104`	`}`
	`105`	`+`
	`106`	`+ /* This is never called because ota.uptade reboots the microcontroller */`
	`107`	`+ return Resume;`
`105`	`108`	`}`
`106`	`109`
`107`	`110`	`OTACloudProcessInterface::State UNOR4OTACloudProcess::reboot() {`