Update repositories.txt #6599
Closed
Update repositories.txt #6599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ ERROR: Arduino Lint found errors with https://github.com/DFRobot/DFRobot_GDL: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @fary99 After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
Because https://github.com/dattasaurabh82/DFRobot_GDL modifies the original library extensively and disrupts our native functionality, we cannot directly merge it. We have extracted the features they added and incorporated them into our own library. Please replace DFRobot_GDL with our URL. Thank you! |
per1234
reviewed
Jul 15, 2025
There was a problem hiding this comment.
@fary99 the answer is the same as what I wrote yesterday:
It was rude of you to submit this redundantly when I already made the effort to clearly explain the situation to you. In the future, please behave in a more responsible manner in your interactions with this repository.
per1234
added
the
status: waiting for information
per1234
reviewed
Jul 19, 2025
There was a problem hiding this comment.
For the sake of a tidy repository, I'm going to close this due to lack of activity.
@fary99 if you ever decide you want to submit these libraries without poisoning the request by unnecessarily shoehorning in a URL change request, please submit another pull request to add the libraries.
I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.
|
@per1234 Sorry for the trouble. I have removed the DFRobot_GDL repository link and resubmitted the PR with the other libraries. Regarding the DFRobot_GDL library, we have already merged @dattasaurabh82 ’s pull requests and added support for new displays. However, the original font files were deleted without updating the corresponding examples, which is currently causing compilation errors in some of the GDL examples on the Arduino Library Manager — for example: @dattasaurabh82 , would you consider removing your repository URL from the Arduino Library Manager so we can submit ours instead? We’ll also make sure to actively maintain the library and handle future PRs in a timely manner. |
|
Sure I will remove it after testing. |
Thank you for your understanding. If you encounter any issues during testing, feel free to submit a pull request — we will review and merge it as soon as possible. |
Upon obtaining @dattasaurabh82's approval, please make a URL change request instead of doing a remove + submit sequence. The procedure for making a URL change request is documented here: https://github.com/arduino/library-registry#changing-the-url-of-a-library-already-in-library-manager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some user libraries provided by DFRobot.
Because https://github.com/dattasaurabh82/DFRobot_GDL modifies the original library extensively and disrupts our native functionality, we cannot directly merge it. We have extracted the features they added and incorporated them into our own library. Please replace DFRobot_GDL with our URL. Thank you!