Skip to content

Commit 794d09b

Browse files
fabik111fabik111
committed
clarify err messages
1 parent 4817bbe commit 794d09b

File tree

2 files changed

+110
-10
lines changed

2 files changed

+110
-10
lines changed

‎arduino-cloud.js

Lines changed: 88 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,17 @@ module.exports = function (RED) {
9595
else
9696
this.status({});
9797
} catch (err) {
98-
console.log(err);
98+
if(err.response && err.response.res && err.response.request){
99+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
100+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
101+
'text: ' + err.response.res.text + '\r'+
102+
'HTTP method: ' + err.response.request.method + '\r' +
103+
'URL request: ' + err.response.request.url
104+
);
105+
}else{
106+
console.log(err);
107+
}
108+
99109
this.status({ fill: "red", shape: "dot", text: "arduino-cloud.status.error-setting-value" });
100110
}
101111
});
@@ -107,7 +117,17 @@ module.exports = function (RED) {
107117
}
108118
}
109119
} catch (err) {
110-
console.log(err);
120+
if(err.response && err.response.res && err.response.request){
121+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
122+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
123+
'text: ' + err.response.res.text + '\r'+
124+
'HTTP method: ' + err.response.request.method + '\r' +
125+
'URL request: ' + err.response.request.url
126+
);
127+
}else{
128+
console.log(err);
129+
}
130+
111131
}
112132
}
113133
}
@@ -167,7 +187,17 @@ module.exports = function (RED) {
167187
this.status({ fill: "grey", shape: "dot", text: str });
168188
}
169189
}catch (err) {
170-
console.log(err);
190+
if(err.response && err.response.res && err.response.request){
191+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
192+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
193+
'text: ' + err.response.res.text + '\r'+
194+
'HTTP method: ' + err.response.request.method + '\r' +
195+
'URL request: ' + err.response.request.url
196+
);
197+
}else{
198+
console.log(err);
199+
}
200+
171201
this.status({ fill: "red", shape: "dot", text: "arduino-cloud.status.error-getting-value" });
172202
}
173203
});
@@ -180,7 +210,17 @@ module.exports = function (RED) {
180210
this.status({ fill: "red", shape: "ring", text: "arduino-cloud.status.connection-error" });
181211
}
182212
} catch (err) {
183-
console.log(err);
213+
if(err.response && err.response.res && err.response.request){
214+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
215+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
216+
'text: ' + err.response.res.text + '\r'+
217+
'HTTP method: ' + err.response.request.method + '\r' +
218+
'URL request: ' + err.response.request.url
219+
);
220+
}else{
221+
console.log(err);
222+
}
223+
184224
this.status({ fill: "red", shape: "dot", text: "arduino-cloud.status.error-getting-value" });
185225
}
186226
}
@@ -220,7 +260,17 @@ module.exports = function (RED) {
220260
this.status({ fill: "red", shape: "ring", text: "arduino-cloud.status.connection-error" });
221261
}
222262
} catch (err) {
223-
console.log(err);
263+
if(err.response && err.response.res && err.response.request){
264+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
265+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
266+
'text: ' + err.response.res.text + '\r'+
267+
'HTTP method: ' + err.response.request.method + '\r' +
268+
'URL request: ' + err.response.request.url
269+
);
270+
}else{
271+
console.log(err);
272+
}
273+
224274
}
225275
}
226276
}
@@ -244,7 +294,17 @@ module.exports = function (RED) {
244294
this.status({});
245295
this.pollTimeoutPoll = setTimeout(() => { this.poll(connectionConfig, pollTime) }, pollTime * 1000);
246296
} catch (err) {
247-
console.log(err);
297+
if(err.response && err.response.res && err.response.request){
298+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
299+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
300+
'text: ' + err.response.res.text + '\r'+
301+
'HTTP method: ' + err.response.request.method + '\r' +
302+
'URL request: ' + err.response.request.url
303+
);
304+
}else{
305+
console.log(err);
306+
}
307+
248308
this.pollTimeoutPoll = setTimeout(() => { this.poll(connectionConfig, pollTime) }, pollTime * 1000);
249309
this.status({ fill: "red", shape: "dot", text: "arduino-cloud.status.error-getting-value" });
250310
}
@@ -285,7 +345,17 @@ module.exports = function (RED) {
285345
else
286346
this.status({});
287347
} catch (err) {
288-
console.log(err);
348+
if(err.response && err.response.res && err.response.request){
349+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
350+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
351+
'text: ' + err.response.res.text + '\r'+
352+
'HTTP method: ' + err.response.request.method + '\r' +
353+
'URL request: ' + err.response.request.url
354+
);
355+
}else{
356+
console.log(err);
357+
}
358+
289359
this.status({ fill: "red", shape: "dot", text: "arduino-cloud.status.error-getting-value" });
290360
}
291361
});
@@ -297,7 +367,17 @@ module.exports = function (RED) {
297367
}
298368
}
299369
} catch (err) {
300-
console.log(err);
370+
if(err.response && err.response.res && err.response.request){
371+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
372+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
373+
'text: ' + err.response.res.text + '\r'+
374+
'HTTP method: ' + err.response.request.method + '\r' +
375+
'URL request: ' + err.response.request.url
376+
);
377+
}else{
378+
console.log(err);
379+
}
380+
301381
this.status({ fill: "red", shape: "dot", text: "arduino-cloud.status.error-getting-value" });
302382
}
303383
}

‎utils/arduino-connection-manager.js

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,17 @@ async function getToken(connectionConfig) {
6565
return { token: token, expires_in: expires_in };
6666
}
6767
} catch (err) {
68-
console.log(err);
68+
if(err.response && err.response.res && err.response.request){
69+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
70+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
71+
'text: ' + err.response.res.text + '\r'+
72+
'HTTP method: ' + err.response.request.method + '\r' +
73+
'URL request: ' + err.response.request.url
74+
);
75+
}else{
76+
console.log(err);
77+
}
78+
6979
}
7080
}
7181

@@ -196,7 +206,17 @@ async function getClientHttp(connectionConfig) {
196206
releaseMutex();
197207
return clientHttp;
198208
} catch (err) {
199-
console.log(err);
209+
if(err.response && err.response.res && err.response.request){
210+
console.log('statusCode: '+ err.response.res.statusCode +'\r'+
211+
'statusMessage: ' + err.response.res.statusMessage + '\r' +
212+
'text: ' + err.response.res.text + '\r'+
213+
'HTTP method: ' + err.response.request.method + '\r' +
214+
'URL request: ' + err.response.request.url
215+
);
216+
}else{
217+
console.log(err);
218+
}
219+
200220
releaseMutex();
201221

202222
}

0 commit comments

Comments
 (0)