Skip to content

Add support for larger Twitter profile images #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for larger Twitter profile images #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73c9496
Add support for larger Twitter profile images
mgomes Jul 6, 2014
8efa4a2
Replace default thumbnail suffix with 400x400
mgomes Jul 6, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/omniauth/strategies/twitter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ def image_url
original_url.sub('normal', 'bigger')
when 'original'
original_url.sub('_normal', '')
when '400x400'
Copy link
Collaborator

@houndci-bot houndci-bot Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

original_url.sub('normal', '400x400')
Copy link
Collaborator

@houndci-bot houndci-bot Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

else
original_url
end
Expand Down
8 changes: 8 additions & 0 deletions spec/omniauth/strategies/twitter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@
expect(subject.info[:image]).to eq('https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_mini.png')
end

it 'should return secure image with size specified' do
Copy link
Collaborator

@houndci-bot houndci-bot Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@options = { :secure_image_url => 'true', :image_size => '400x400' }
Copy link
Collaborator

@houndci-bot houndci-bot Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

allow(subject).to receive(:raw_info).and_return(
{ 'profile_image_url_https' => 'https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_normal.png' }
Copy link
Collaborator

@houndci-bot houndci-bot Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant curly braces around a hash parameter.
Line is too long. [133/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

)
expect(subject.info[:image]).to eq('https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_400x400.png')
Copy link
Collaborator

@houndci-bot houndci-bot Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [135/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

end

it 'should return normal image by default' do
allow(subject).to receive(:raw_info).and_return(
{ 'profile_image_url' => 'http://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_normal.png' }
Expand Down