fix: support old phoenix generators (#365)

* Move new templates to new folder, return old templates

* Generalize writing templates and switch by phx version

* Return old test for generating live templates

* Remove dbg call in template

* Add phx_version option and based on that switch

* Test both templating with/without phx_version option

Author: ken-kost

lib/ash_phoenix/gen/live.ex

@@ -10,14 +10,13 @@ if Code.ensure_loaded?(Igniter) do
         Keyword.fetch!(options, :resource_plural) ||
           resource |> Module.split() |> List.last() |> Macro.underscore() |> Inflex.pluralize()
 
-      opts = []
+      opts = [
+        interactive?: true,
+        resource_plural: resource_plural,
+        phx_version: options[:phx_version]
+      ]
 
-      generate(
-        igniter,
-        domain,
-        resource,
-        Keyword.put(opts, :interactive?, true) |> Keyword.put(:resource_plural, resource_plural)
-      )
+      generate(igniter, domain, resource, opts)
     end
 
     def generate(igniter, domain, resource, opts \\ []) do
@@ -80,38 +79,7 @@ if Code.ensure_loaded?(Igniter) do
         end
 
       igniter =
-        write_formatted_template(
-          igniter,
-          "ash_phoenix.gen.live/index.ex.eex",
-          "index.ex",
-          web_live,
-          assigns,
-          generate_opts
-        )
-
-      igniter =
-        if assigns[:update_action] || assigns[:create_action] do
-          write_formatted_template(
-            igniter,
-            "ash_phoenix.gen.live/form.ex.eex",
-            "form.ex",
-            web_live,
-            assigns,
-            generate_opts
-          )
-        else
-          igniter
-        end
-
-      igniter =
-        write_formatted_template(
-          igniter,
-          "ash_phoenix.gen.live/show.ex.eex",
-          "show.ex",
-          web_live,
-          assigns,
-          generate_opts
-        )
+        write_formatted_templates(igniter, web_live, assigns, generate_opts, opts[:phx_version])
 
       igniter =
         if opts[:interactive?] do
@@ -144,21 +112,37 @@ if Code.ensure_loaded?(Igniter) do
       |> Enum.reject(&is_nil/1)
     end
 
-    defp write_formatted_template(igniter, path, destination, web_live, assigns, generate_opts) do
-      destination_path =
-        web_live
-        |> Path.join(destination)
+    defp write_formatted_templates(igniter, web_live, assigns, generate_opts, phx_version) do
+      {path, igniter} =
+        if String.starts_with?(phx_version, "1.8") do
+          message = """
+          if Layouts.app causes a problem, you may be on an older version of the generators,
+          try deleting the files and running the command again with --phx-version 1.7
+          """
+
+          {"new", Igniter.add_notice(igniter, message)}
+        else
+          {"old", igniter}
+        end
+
+      template_folder = template_folder(path)
+      action? = assigns[:update_action] || assigns[:create_action]
+
+      Enum.reduce(File.ls!(template_folder), igniter, fn
+        "form.ex.eex", igniter when is_nil(action?) ->
+          igniter
 
-      {formatter_function, _options} =
-        Mix.Tasks.Format.formatter_for_file(destination_path)
+        file, igniter ->
+          destination = String.replace_trailing(file, ".eex", "")
+          destination_path = Path.join(web_live, destination)
 
-      contents =
-        path
-        |> template()
-        |> EEx.eval_file(assigns: assigns)
-        |> formatter_function.()
+          {formatter_function, _options} =
+            Mix.Tasks.Format.formatter_for_file(destination_path)
 
-      Igniter.create_new_file(igniter, destination_path, contents, generate_opts)
+          path = Path.join(template_folder, file)
+          contents = path |> EEx.eval_file(assigns: assigns) |> formatter_function.()
+          Igniter.create_new_file(igniter, destination_path, contents, generate_opts)
+      end)
     end
 
     defp add_resource_assigns(assigns, resource, opts) do
@@ -341,8 +325,10 @@ if Code.ensure_loaded?(Igniter) do
       Igniter.Libs.Phoenix.web_module(igniter)
     end
 
-    defp template(path) do
-      :code.priv_dir(:ash_phoenix) |> Path.join("templates") |> Path.join(path)
+    defp template_folder(path) do
+      :code.priv_dir(:ash_phoenix)
+      |> Path.join("templates/ash_phoenix.gen.live")
+      |> Path.join(path)
     end
 
     def inputs(resource, action) do

lib/mix/tasks/ash_phoenix.gen.live.ex

@@ -22,6 +22,7 @@ if Code.ensure_loaded?(Igniter) do
     * `--domain`   - Existing domain
     * `--resource` - Existing resource module name
     * `--resource-plural` - Pluralized version resource name for the route paths and templates
+    * `--phx-version` - Phoenix version 1.7 (old) or 1.8 (new). Defaults to 1.8
     """
 
     def info(_argv, _composing_task) do
@@ -34,10 +35,11 @@ if Code.ensure_loaded?(Igniter) do
           domain: :string,
           resource: :string,
           resourceplural: :string,
-          resource_plural: :string
+          resource_plural: :string,
+          phx_version: :string
         ],
         # Default values for the options in the `schema`.
-        defaults: [],
+        defaults: [phx_version: "1.8"],
         # CLI aliases
         aliases: [],
         # A list of options in the schema that are required

priv/templates/ash_phoenix.gen.live/form.ex.eex renamed to priv/templates/ash_phoenix.gen.live/new/form.ex.eex

@@ -51,7 +51,6 @@ defmodule <%= inspect Module.concat(@web_module, @resource_alias) %>Live.Form do
 
     action = if is_nil(<%= @resource_singular %>), do: "New", else: "Edit"
     page_title = action <> " " <> <%= inspect @resource_human_singular %>
-  dbg(params)
     {:ok,
      socket
      |> assign(:return_to, return_to(params["return_to"]))

priv/templates/ash_phoenix.gen.live/index.ex.eex renamed to priv/templates/ash_phoenix.gen.live/new/index.ex.eex

@@ -0,0 +1,102 @@
+defmodule <%= inspect Module.concat(@web_module, @resource_alias) %>Live.FormComponent do
+
+  use <%= @web_module %>, :live_component
+
+  @impl true
+  def render(assigns) do
+    ~H"""
+    <div>
+      <.header>
+        <%%= @title %>
+        <:subtitle>Use this form to manage <%= @resource_singular %> records in your database.</:subtitle>
+      </.header>
+
+      <.simple_form
+        for={@form}
+        id="<%= @resource_singular %>-form"
+        phx-target={@myself}
+        phx-change="validate"
+        phx-submit="save"
+      >
+        <%= cond do %>
+          <% @create_action && @update_action -> %>
+            <%= if @create_inputs == @update_inputs do %>
+              <%= @create_inputs %>
+            <% else %>
+              <%%= if @form.source.type == :create do %>
+                <%= @create_inputs %>
+              <%% end %>
+              <%%= if @form.source.type == :update do %>
+                <%= @update_inputs %>
+              <%% end %>
+            <% end %>
+          <% @create_action -> %>
+            <%= @create_inputs %>
+          <% @update_action -> %>
+            <%= @update_inputs %>
+        <% end %>
+        <:actions>
+          <.button phx-disable-with="Saving...">Save <%= @resource_human_singular %></.button>
+        </:actions>
+      </.simple_form>
+    </div>
+    """
+  end
+
+  @impl true
+  def update(assigns, socket) do
+    {:ok,
+     socket
+     |> assign(assigns)
+     |> assign_form()}
+  end
+
+  @impl true
+  def handle_event("validate", %{"<%= @resource_singular %>" => <%= @resource_singular %>_params}, socket) do
+    {:noreply, assign(socket, form: AshPhoenix.Form.validate(socket.assigns.form, <%= @resource_singular %>_params))}
+  end
+
+  def handle_event("save", %{"<%= @resource_singular %>" => <%= @resource_singular %>_params}, socket) do
+    case AshPhoenix.Form.submit(socket.assigns.form, params: <%= @resource_singular %>_params) do
+      {:ok, <%= @resource_singular %>} ->
+        notify_parent({:saved, <%= @resource_singular %>})
+
+      socket =
+        socket
+        <%= cond do %>
+          <% @update_action && @create_action -> %>
+            |> put_flash(:info, "<%= @resource_human_singular %> #{socket.assigns.form.source.type}d successfully")
+          <% @update_action -> %>
+              |> put_flash(:info, "<%= @resource_human_singular %> updated successfully")
+          <% @create_action -> %>
+              |> put_flash(:info, "<%= @resource_human_singular %> created successfully")
+        <% end %>
+        |> push_patch(to: socket.assigns.patch)
+
+      {:noreply, socket}
+
+      {:error, form} ->
+        {:noreply, assign(socket, form: form)}
+    end
+  end
+
+  defp notify_parent(msg), do: send(self(), {__MODULE__, msg})
+
+  defp assign_form(%{assigns: %{<%= @resource_singular %>: <%= @resource_singular %>}} = socket) do
+    form =
+      <%= cond do %>
+        <% @update_action && @create_action -> %>
+          if <%= @resource_singular %> do
+            AshPhoenix.Form.for_update(<%= @resource_singular %>, <%= inspect @update_action.name %>, as: <%= inspect @resource_singular %><%= @actor_opt %>)
+          else
+            AshPhoenix.Form.for_create(<%= @resource %>, <%= inspect @create_action.name %>, as: <%= inspect @resource_singular %><%= @actor_opt %>)
+          end
+        <% @update_action -> %>
+          AshPhoenix.Form.for_update(<%= @resource_singular %>, <%= inspect @update_action.name %>, as: <%= inspect @resource_singular %><%= @actor_opt %>)
+        <% @create_action -> %>
+          AshPhoenix.Form.for_create(<%= @resource_singular %>, <%= inspect @create_action.name %>, as: <%= inspect @resource_singular %><%= @actor_opt %>)
+      <% end %>
+
+    assign(socket, form: to_form(form))
+  end
+end