improvement: add c:AshPostgres.Repo.create_schemas_in_migrations? callback

Author: zachdaniel

lib/migration_generator/migration_generator.ex

@@ -1361,14 +1361,20 @@ defmodule AshPostgres.MigrationGenerator do
 
   defp group_into_phases(
          [
-           %Operation.CreateTable{table: table, schema: schema, multitenancy: multitenancy} | rest
+           %Operation.CreateTable{
+             table: table,
+             schema: schema,
+             multitenancy: multitenancy,
+             repo: repo
+           }
+           | rest
          ],
          nil,
          acc
        ) do
     group_into_phases(
       rest,
-      %Phase.Create{table: table, schema: schema, multitenancy: multitenancy},
+      %Phase.Create{table: table, schema: schema, multitenancy: multitenancy, repo: repo},
       acc
     )
   end
@@ -2010,6 +2016,7 @@ defmodule AshPostgres.MigrationGenerator do
       %Operation.CreateTable{
         table: snapshot.table,
         schema: snapshot.schema,
+        repo: snapshot.repo,
         multitenancy: snapshot.multitenancy,
         old_multitenancy: empty_snapshot.multitenancy
       }

lib/migration_generator/operation.ex

@@ -145,7 +145,7 @@ defmodule AshPostgres.MigrationGenerator.Operation do
 
   defmodule CreateTable do
     @moduledoc false
-    defstruct [:table, :schema, :multitenancy, :old_multitenancy]
+    defstruct [:table, :schema, :multitenancy, :old_multitenancy, :repo]
   end
 
   defmodule AddAttribute do

lib/migration_generator/phase.ex

@@ -3,18 +3,24 @@ defmodule AshPostgres.MigrationGenerator.Phase do
 
   defmodule Create do
     @moduledoc false
-    defstruct [:table, :schema, :multitenancy, operations: [], commented?: false]
+    defstruct [:table, :schema, :multitenancy, :repo, operations: [], commented?: false]
 
     import AshPostgres.MigrationGenerator.Operation.Helper, only: [as_atom: 1]
 
-    def up(%{schema: schema, table: table, operations: operations, multitenancy: multitenancy}) do
+    def up(%{
+          schema: schema,
+          table: table,
+          operations: operations,
+          multitenancy: multitenancy,
+          repo: repo
+        }) do
       if multitenancy.strategy == :context do
         "create table(:#{as_atom(table)}, primary_key: false, prefix: prefix()) do\n" <>
           Enum.map_join(operations, "\n", fn operation -> operation.__struct__.up(operation) end) <>
           "\nend"
       else
         {pre_create, opts} =
-          if schema do
+          if schema && repo.create_schemas_in_migrations?() do
             {"execute(\"CREATE SCHEMA IF NOT EXISTS #{schema}\")" <> "\n\n",
              ", prefix: \"#{schema}\""}
           else

lib/repo.ex

@@ -78,6 +78,9 @@ defmodule AshPostgres.Repo do
   @doc "The default prefix(postgres schema) to use when building queries"
   @callback default_prefix() :: String.t()
 
+  @doc "Whether or not to create schemas for tables when generating migrations"
+  @callback create_schemas_in_migrations?() :: boolean()
+
   @doc "Whether or not to explicitly start and close a transaction for each action, even if there are no transaction hooks. Defaults to `true`."
   @callback prefer_transaction?() :: boolean
 
@@ -135,6 +138,7 @@ defmodule AshPostgres.Repo do
       def installed_extensions, do: []
       def tenant_migrations_path, do: nil
       def migrations_path, do: nil
+      def create_schemas_in_migrations?, do: true
       def default_prefix, do: "public"
       def override_migration_type(type), do: type
       def create?, do: true
@@ -304,6 +308,7 @@ defmodule AshPostgres.Repo do
                      prefer_transaction?: 0,
                      prefer_transaction_for_atomic_updates?: 0,
                      tenant_migrations_path: 0,
+                     create_schemas_in_migrations?: 0,
                      migrations_path: 0,
                      default_prefix: 0,
                      override_migration_type: 1,