Skip to content

Commit beb1e4a

Browse files
committed
Devise pixel ratio should be used by default if using Chrome commands
1 parent a6fa040 commit beb1e4a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/main/java/com/assertthat/selenium_shutterbug/core/Shutterbug.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,13 @@ public static PageSnapshot shootPage(WebDriver driver, ScrollStrategy scroll, bo
9898
* @return PageSnapshot instance
9999
*/
100100
public static PageSnapshot shootPage(WebDriver driver, ScrollStrategy scroll, int scrollTimeout, boolean useDevicePixelRatio) {
101-
Browser browser = new Browser(driver, useDevicePixelRatio);
101+
Browser browser;
102+
if(scroll.equals(ScrollStrategy.WHOLE_PAGE_CHROME)){
103+
//should use devicePixelRatio by default as chrome command executor makes screenshot account for that
104+
browser = new Browser(driver, true);
105+
}else {
106+
browser = new Browser(driver, useDevicePixelRatio);
107+
}
102108
browser.setScrollTimeout(scrollTimeout);
103109
PageSnapshot pageScreenshot = new PageSnapshot(driver, browser.getDevicePixelRatio());
104110
switch (scroll) {

0 commit comments

Comments
 (0)