Refactor throwing ecxeption if element outside the viewport

Author: glibas

src/main/java/com/assertthat/selenium_shutterbug/core/ElementSnapshot.java

@@ -5,9 +5,15 @@
 
 package com.assertthat.selenium_shutterbug.core;
 
+import com.assertthat.selenium_shutterbug.utils.image.ImageProcessor;
+import com.assertthat.selenium_shutterbug.utils.web.Coordinates;
+import com.assertthat.selenium_shutterbug.utils.web.ElementOutsideViewportException;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
 
+import java.awt.image.BufferedImage;
+import java.awt.image.RasterFormatException;
+
 /**
  * Created by Glib_Briia on 17/06/2016.
  */
@@ -17,6 +23,14 @@ public class ElementSnapshot extends Snapshot {
         this.driver = driver;
     }
 
+    protected void setImage(BufferedImage image, Coordinates coords) {
+        try {
+            self().image = ImageProcessor.getElement(image, coords);
+        } catch (RasterFormatException rfe) {
+            throw new ElementOutsideViewportException(ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE, rfe);
+        }
+    }
+
     @Override
     protected ElementSnapshot self() {
         return this;

src/main/java/com/assertthat/selenium_shutterbug/core/PageSnapshot.java

@@ -34,7 +34,7 @@ public PageSnapshot highlight(WebElement element) {
         try {
             highlight(element, Color.red, 3);
         } catch (RasterFormatException rfe) {
-            throw new ElementOutsideViewportException("Try to apply ScrollStrategy", rfe);
+            throw new ElementOutsideViewportException(ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE, rfe);
         }
         return this;
     }
@@ -52,7 +52,7 @@ public PageSnapshot highlight(WebElement element, Color color, int lineWidth) {
         try {
             image = ImageProcessor.highlight(image, new Coordinates(element), color, lineWidth);
         } catch (RasterFormatException rfe) {
-            throw new ElementOutsideViewportException("Try to apply ScrollStrategy", rfe);
+            throw new ElementOutsideViewportException(ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE, rfe);
         }
         return this;
     }
@@ -71,7 +71,7 @@ public PageSnapshot highlightWithText(WebElement element, String text) {
         try {
             highlightWithText(element, Color.red, 3, text, Color.red, new Font("Serif", Font.BOLD, 20));
         } catch (RasterFormatException rfe) {
-            throw new ElementOutsideViewportException("Try to apply ScrollStrategy", rfe);
+            throw new ElementOutsideViewportException(ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE, rfe);
         }
         return this;
     }
@@ -94,7 +94,7 @@ public PageSnapshot highlightWithText(WebElement element, Color elementColor, in
            Coordinates coords = new Coordinates(element);
            image = ImageProcessor.addText(image, coords.getX(), coords.getY() - textFont.getSize() / 2, text, textColor, textFont);
        } catch (RasterFormatException rfe) {
-           throw new ElementOutsideViewportException("Try to apply ScrollStrategy", rfe);
+           throw new ElementOutsideViewportException(ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE, rfe);
        }
         return this;
     }
@@ -119,7 +119,7 @@ public PageSnapshot blur(WebElement element) {
         try {
             image = ImageProcessor.blurArea(image, new Coordinates(element));
         }catch(RasterFormatException rfe) {
-            throw new ElementOutsideViewportException("Try to apply ScrollStrategy", rfe);
+            throw new ElementOutsideViewportException(ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE, rfe);
         }
         return this;
     }
@@ -135,7 +135,7 @@ public PageSnapshot monochrome(WebElement element) {
         try {
             image = ImageProcessor.monochromeArea(image, new Coordinates(element));
         } catch (RasterFormatException rfe) {
-            throw new ElementOutsideViewportException("Try to apply ScrollStrategy", rfe);
+            throw new ElementOutsideViewportException(ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE, rfe);
         }
         return this;
     }
@@ -150,7 +150,7 @@ public PageSnapshot blurExcept(WebElement element) {
         try{
             image = ImageProcessor.blurExceptArea(image, new Coordinates(element));
         }catch(RasterFormatException rfe){
-            throw new ElementOutsideViewportException("Try to apply ScrollStrategy",rfe);
+            throw new ElementOutsideViewportException(ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE,rfe);
         }
         return this;
     }

src/main/java/com/assertthat/selenium_shutterbug/core/Shutterbug.java

@@ -67,8 +67,7 @@ public static ElementSnapshot shootElement(WebDriver driver, WebElement element)
         Browser browser = new Browser(driver);
         ElementSnapshot elementSnapshot = new ElementSnapshot(driver);
         browser.scrollToElement(element);
-        elementSnapshot.setImage(browser.takeScreenshot());
-        elementSnapshot.setImage(ImageProcessor.getElement(elementSnapshot.getImage(), browser.getBoundingClientRect(element)));
+        elementSnapshot.setImage(browser.takeScreenshot(),browser.getBoundingClientRect(element));
         return elementSnapshot;
     }
 }

src/main/java/com/assertthat/selenium_shutterbug/core/Snapshot.java

@@ -23,12 +23,13 @@
  */
 public abstract class Snapshot<T extends Snapshot> {
 
-    private static final String extension = "PNG";
+    private static final String EXTENSION = "PNG";
+    protected static final String ELEMENT_OUT_OF_VIEWPORT_EX_MESSAGE = "Use ScrollStrategy.HORIZONTALLY,  ScrollStrategy.VERTICALLY or ScrollStrategy.BOTH_DIRECTIONS to shoot the element outside the viewport";
     protected BufferedImage image;
     protected BufferedImage thumbnailImage;
     protected WebDriver driver;
     private String fileName = new SimpleDateFormat("yyyy_MM_dd_HH_mm_ss_SSS").format(new Date())
-            + "." + extension.toLowerCase();
+            + "." + EXTENSION.toLowerCase();
     private Path location = Paths.get("./screenshots/");
     private String title;
 
@@ -41,7 +42,7 @@ public abstract class Snapshot<T extends Snapshot> {
      */
     public T withName(String name) {
         if (name != null) {
-            fileName = name + "." + extension.toLowerCase();
+            fileName = name + "." + EXTENSION.toLowerCase();
         }
         return self();
     }
@@ -72,7 +73,7 @@ public T withThumbnail(String path, String name, double scale) {
             thumbnailFile.mkdirs();
         }
         thumbnailImage=ImageProcessor.scale(image,scale);
-        FileUtil.writeImage(thumbnailImage, extension, thumbnailFile);
+        FileUtil.writeImage(thumbnailImage, EXTENSION, thumbnailFile);
         return self();
     }
 
@@ -133,7 +134,7 @@ public void save() {
         if (title != null && !title.isEmpty()) {
             image = ImageProcessor.addTitle(image, title, Color.red, new Font("Serif", Font.BOLD, 20));
         }
-        FileUtil.writeImage(image, extension, screenshotFile);
+        FileUtil.writeImage(image, EXTENSION, screenshotFile);
     }
 
     /**