Fixed pyflakes issues

Author: astrofrog

pyproject.toml

@@ -187,6 +187,7 @@ lint.select = [
   "B",  # flake8-bugbear
   "I",  # isort
   "UP",  # pyupgrade
+  "F",   # pyflakes
 ]
 
 [tool.ruff.lint.extend-per-file-ignores]

reproject/adaptive/tests/test_core.py

@@ -1,11 +1,9 @@
 # Licensed under a 3-clause BSD style license - see LICENSE.rst
 
-import os
 from itertools import product
 
 import numpy as np
 import pytest
-from astropy import units as u
 from astropy.io import fits
 from astropy.utils.data import get_pkg_data_filename
 from astropy.wcs import WCS

reproject/array_utils.py

@@ -176,8 +176,8 @@ def map_coordinates(
 
             # Adjust chunks to add padding
             for idim, slc in enumerate(chunk):
-                start = max(0, slc.start - 10)
-                stop = min(original_shape[idim], slc.stop + 10)
+                start = max(0, slc.start - padding)
+                stop = min(original_shape[idim], slc.stop + padding)
                 chunk[idim] = slice(start, stop)
 
             chunk = tuple(chunk)

reproject/common.py

@@ -305,7 +305,7 @@ def reproject_single_block(a, array_or_path, block_info=None):
             array_out_dask = da.empty(shape_out)
             array_out_dask = array_out_dask.rechunk(block_size_limit=64 * 1024**2, **rechunk_kwargs)
 
-        logger.info(f"Setting up output dask array with map_blocks")
+        logger.info("Setting up output dask array with map_blocks")
 
         result = da.map_blocks(
             reproject_single_block,
@@ -364,7 +364,7 @@ def reproject_single_block(a, array_or_path, block_info=None):
 
             result = da.from_zarr(zarr_path)
 
-        logger.info(f"Copying output zarr array into output Numpy arrays")
+        logger.info("Copying output zarr array into output Numpy arrays")
 
         if return_footprint:
             da.store(

reproject/hips/high_level.py

@@ -8,16 +8,12 @@
 from pathlib import Path
 
 import numpy as np
-from astropy import units as u
 from astropy.coordinates import ICRS, BarycentricTrueEcliptic, Galactic
 from astropy.io import fits
 from astropy.nddata import block_reduce
-from astropy.wcs import WCS
 from astropy_healpix import (
     HEALPix,
     level_to_nside,
-    nside_to_level,
-    pixel_resolution_to_nside,
 )
 from PIL import Image
 

reproject/hips/tests/test_high_level.py

@@ -1,4 +1,3 @@
-import os
 import re
 
 import numpy as np

reproject/hips/utils.py

@@ -1,8 +1,14 @@
 import os
 
 import numpy as np
+from astropy.wcs import WCS
 from astropy.wcs.utils import celestial_frame_to_wcs
-from astropy_healpix import HEALPix, level_to_nside
+from astropy_healpix import (
+    HEALPix,
+    level_to_nside,
+    nside_to_level,
+    pixel_resolution_to_nside,
+)
 
 __all__ = ["tile_header", "tile_filename", "make_tile_folders", "determine_healpix_level"]
 

reproject/interpolation/tests/test_core.py

@@ -5,7 +5,6 @@
 import dask.array as da
 import numpy as np
 import pytest
-from astropy import units as u
 from astropy.io import fits
 from astropy.utils.data import get_pkg_data_filename
 from astropy.wcs import WCS

reproject/mosaicking/coadd.py

@@ -383,7 +383,7 @@ def reproject_and_coadd(
 
                 if intermediate_memmap:
                     # Remove the reference to the memmap before trying to remove the file itself
-                    logger.info(f"Removing memory-mapped weight array")
+                    logger.info("Removing memory-mapped weight array")
                     weights = None
                     try:
                         os.remove(weights_path)
@@ -396,7 +396,7 @@ def reproject_and_coadd(
             # output image is empty (due e.g. to no overlap).
 
             if on_the_fly:
-                logger.info(f"Adding reprojected array to final array")
+                logger.info("Adding reprojected array to final array")
                 # By default, values outside of the footprint are set to NaN
                 # but we set these to 0 here to avoid getting NaNs in the
                 # means/sums.
@@ -412,7 +412,7 @@ def reproject_and_coadd(
                 if intermediate_memmap:
                     # Remove the references to the memmaps themesleves before
                     # trying to remove the files thermselves.
-                    logger.info(f"Removing memory-mapped array and footprint arrays")
+                    logger.info("Removing memory-mapped array and footprint arrays")
                     array = None
                     footprint = None
                     try:
@@ -422,12 +422,12 @@ def reproject_and_coadd(
                         pass
 
             else:
-                logger.info(f"Adding reprojected array to list to combine later")
+                logger.info("Adding reprojected array to list to combine later")
                 arrays.append(array)
 
         # If requested, try and match the backgrounds.
         if match_background and len(arrays) > 1:
-            logger.info(f"Match backgrounds")
+            logger.info("Match backgrounds")
             offset_matrix = determine_offset_matrix(arrays)
             corrections = solve_corrections_sgd(offset_matrix)
             if background_reference:
@@ -448,7 +448,7 @@ def reproject_and_coadd(
                     output_footprint[array.view_in_original_array] += array.footprint
 
             if combine_function == "mean":
-                logger.info(f"Handle normalization of output array")
+                logger.info("Handle normalization of output array")
                 with np.errstate(invalid="ignore"):
                     output_array /= output_footprint
 

reproject/tests/data/generate_asdf.py

@@ -82,7 +82,6 @@ def generate_asdf(input_file="aia_171_level1.fits", output_file="aia_171_level1.
 
     aia_map = sunpy.map.Map(input_file)
 
-    spatial_unit = aia_map.spatial_units[0]
     transform = generate_celestial_transform(
         crpix=aia_map.reference_pixel,
         cdelt=aia_map.scale,