Skip to content

[Feature Request]: Pass quality argument to get_screenshot method #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
Airmask1 opened this issue Apr 29, 2025 · 1 comment
Open
2 tasks done

[Feature Request]: Pass quality argument to get_screenshot method #125

Airmask1 opened this issue Apr 29, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@Airmask1
Copy link

Airmask1 commented Apr 29, 2025

Checklist before requesting

  • I have searched for similar feature requests and didn't find a duplicate.
  • I have checked the documentation to confirm this feature doesn't already exist.

Problem Statement

def screenshot(
cls, fmt: str = 'jpeg', quality: int = 100, clip: dict = None
) -> dict:
The class method have quality argument (in case someone like me want to use it), but you should expand the whole class and pass Page to browser which is little bit unnecessary.

Proposed Solution

Maybe just add argument to: async def get_screenshot(self, path: str) method which executes screenshot class method under the hood ?

Alternatives Considered

No response

Additional Context

No response

Importance

Nice to have

Contribution

None

@Airmask1 Airmask1 added the enhancement New feature or request label Apr 29, 2025
@thalissonvs
Copy link
Member

Hi @Airmask1,

Thanks for the suggestion! This is already being worked on in the new version of Pydoll, which will be released soon. Below there is a preview

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants