Skip to content

Commit 06a88a7

Browse files
committed
plugin should remain unchanged
1 parent 8799e14 commit 06a88a7

File tree

4 files changed

+29
-32
lines changed

4 files changed

+29
-32
lines changed

inject-generator/src/main/java/io/avaje/inject/generator/ExternalProvider.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,11 @@ static void registerPluginProvidedTypes(ScopeInfo defaultScope) {
124124
continue;
125125
}
126126
APContext.logNote("Loaded Plugin: %s", plugin.getClass().getTypeName());
127-
for (final var provide : plugin.providesBeans()) {
128-
defaultScope.pluginProvided(provide);
127+
for (final var provide : plugin.provides()) {
128+
defaultScope.pluginProvided(provide.getTypeName());
129129
}
130-
for (final var provide : plugin.providesAspectBeans()) {
131-
defaultScope.pluginProvided(Util.wrapAspect(provide));
130+
for (final var provide : plugin.providesAspects()) {
131+
defaultScope.pluginProvided(Util.wrapAspect(provide.getTypeName()));
132132
}
133133
}
134134
}

inject-gradle-plugin/src/main/java/io/avaje/inject/plugin/AvajeInjectPlugin.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ private void writeProvides(Project project) {
4949
try (var classLoader = classLoader(project);
5050
var pluginWriter = createFileWriter(outputDir.getPath(), "avaje-plugins.csv");
5151
var moduleCSV = createFileWriter(outputDir.getPath(), "avaje-module-dependencies.csv")) {
52-
writeProvidedPlugins(classLoader, pluginWriter);
53-
writeModuleCSV(classLoader, moduleCSV);
52+
writeProvidedPlugins(classLoader, pluginWriter);
53+
writeModuleCSV(classLoader, moduleCSV);
5454
} catch (IOException e) {
5555
throw new GradleException("Failed to write avaje-module-provides", e);
5656
}
@@ -74,11 +74,11 @@ private void writeProvidedPlugins(ClassLoader classLoader, FileWriter pluginWrit
7474
final List<String> provides = new ArrayList<>();
7575
final var typeName = plugin.getClass().getTypeName();
7676
System.out.println("Loaded Plugin: " + typeName);
77-
for (final var provide : plugin.providesBeans()) {
78-
provides.add(provide);
77+
for (final var provide : plugin.provides()) {
78+
provides.add(provide.getTypeName());
7979
}
80-
for (final var provide : plugin.providesAspectBeans()) {
81-
provides.add(wrapAspect(provide));
80+
for (final var provide : plugin.providesAspects()) {
81+
provides.add(wrapAspect(provide.getCanonicalName()));
8282
}
8383
pluginEntries.put(typeName, provides);
8484
}
@@ -104,7 +104,8 @@ private URLClassLoader classLoader(Project project) {
104104

105105
private static URL[] createClassPath(Project project) {
106106
try {
107-
Set<File> compileClasspath = project.getConfigurations().getByName("compileClasspath").resolve();
107+
Set<File> compileClasspath =
108+
project.getConfigurations().getByName("compileClasspath").resolve();
108109
final List<URL> urls = new ArrayList<>(compileClasspath.size());
109110
for (File file : compileClasspath) {
110111
urls.add(file.toURI().toURL());

inject-maven-plugin/src/main/java/io/avaje/inject/mojo/AutoProvidesMojo.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,9 @@ private void writeProvidedPlugins(URLClassLoader newClassLoader, FileWriter plug
109109
final List<String> provides = new ArrayList<>();
110110
final var typeName = plugin.getClass();
111111
log.info("Loaded Plugin: " + typeName);
112-
Collections.addAll(provides, plugin.providesBeans());
112+
for (final var provide : plugin.provides()) {
113+
provides.add(provide.getTypeName());
114+
}
113115
for (final var provide : plugin.providesAspects()) {
114116
provides.add(wrapAspect(provide.getCanonicalName()));
115117
}
Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
package io.avaje.inject.spi;
22

3-
import java.lang.reflect.Type;
4-
import java.util.Arrays;
5-
63
import io.avaje.inject.BeanScopeBuilder;
74

5+
import java.lang.reflect.Type;
6+
87
/**
98
* A Plugin that can be applied when creating a bean scope.
109
*
@@ -13,32 +12,27 @@
1312
*/
1413
public interface InjectPlugin extends InjectExtension {
1514

16-
/** Empty array of classes. */
15+
/**
16+
* Empty array of classes.
17+
*/
1718
Class<?>[] EMPTY_CLASSES = {};
1819

19-
/** Empty array of classes. */
20-
String[] EMPTY_STRINGS = {};
21-
22-
/** Apply the plugin to the scope builder. */
20+
/**
21+
* Apply the plugin to the scope builder.
22+
*/
2323
void apply(BeanScopeBuilder builder);
2424

25-
/** Return the classes that the plugin provides. */
25+
/**
26+
* Return the classes that the plugin provides.
27+
*/
2628
default Type[] provides() {
2729
return EMPTY_CLASSES;
2830
}
2931

30-
/** Return the type names of types this module explicitly provides to other modules. */
31-
default String[] providesBeans() {
32-
return Arrays.stream(provides()).map(Type::getTypeName).toArray(String[]::new);
33-
}
34-
35-
/** Return the aspect classes that the plugin provides. */
32+
/**
33+
* Return the aspect classes that the plugin provides.
34+
*/
3635
default Class<?>[] providesAspects() {
3736
return EMPTY_CLASSES;
3837
}
39-
40-
/** Return the type names of types this module explicitly provides to other modules. */
41-
default String[] providesAspectBeans() {
42-
return Arrays.stream(providesAspects()).map(Type::getTypeName).toArray(String[]::new);
43-
}
4438
}

0 commit comments

Comments
 (0)