Version 4 seems to break workflows

[magandrez]

Describe the bug

With this step:

  - name: Configure AWS credentials
    uses: aws-actions/configure-aws-credentials@v4.2.1
    with:
      role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
      aws-region: ${{ secrets.AWS_REGION }}

All is good and dandy.

With this:

  - name: Configure AWS credentials
    uses: aws-actions/configure-aws-credentials@v4
    with:
      role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
      aws-region: ${{ secrets.AWS_REGION }}

I get:

##[debug]Evaluating condition for step: 'Configure AWS credentials'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Configure AWS credentials
##[debug]Register post job cleanup for action: aws-actions/configure-aws-credentials@v4
##[debug]Loading inputs
##[debug]Evaluating: secrets.AWS_ROLE_ARN
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'AWS_ROLE_ARN'
##[debug]=> null
##[debug]Result: null
##[debug]Evaluating: secrets.AWS_REGION
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'AWS_REGION'
##[debug]=> null
##[debug]Result: null
##[debug]Loading env
Run aws-actions/configure-aws-credentials@v4
Error: Input required and not supplied: aws-region
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Configure AWS credentials

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

I expect the latest version (v4.3.1) to behave as v4.2.1, given no major change to the interface was documented.

Current Behavior

Credentials are not obtained.

Reproduction Steps

See above description.

Possible Solution

No response

Additional Information/Context

No response

[lehmanmj]

Hi magandrez, I noticed that in your example, you're using aws-actions/configure-aws-credentials@v4 instead of aws-actions/configure-aws-credentials@v4.3.1

The v4 tag actually points to v4.0.2, not the latest 4.x release.

Does the workflow work if you use the v4.3.1 tag?

[magandrez]

Hi magandrez, I noticed that in your example, you're using aws-actions/configure-aws-credentials@v4 instead of aws-actions/configure-aws-credentials@v4.3.1

The v4 tag actually points to v4.0.2, not the latest 4.x release.

Does the workflow work if you use the v4.3.1 tag?

Hi,

I did not try setting it to v4.3.1 because I assumed the utility is relying in the convention that, referencing major is latest major (that is v4.3.1), referencing minor is latest minor, that is, v4.2.1, etc.

The issue remains, if the interface has changed in latest v4 version, it is either a regression or you are breaking semver (i.e.: the changes imply a new major)

[lehmanmj]

I assumed the utility is relying in the convention that, referencing major is latest major (that is v4.3.1), referencing minor is latest minor, that is, v4.2.1, etc.

We actually no longer use this convention, as changing which hash the major version tag refers to can cause problems for Dependabot.

Regarding changes in the v4 version, I tried running both of your example steps:

- name: test 4.2.1
    uses: aws-actions/configure-aws-credentials@v4.2.1
        with: 
          role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
          aws-region: ${{ secrets.AWS_REGION }}

And

- name: test 4
        uses: aws-actions/configure-aws-credentials@v4
        with:
          role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
          aws-region: ${{ secrets.AWS_REGION }}

Both versions worked, and so I was unable to reproduce the error. Did you change anything else between running the two steps?

[magandrez]

I assumed the utility is relying in the convention that, referencing major is latest major (that is v4.3.1), referencing minor is latest minor, that is, v4.2.1, etc.

We actually no longer use this convention, as changing which hash the major version tag refers to can cause problems for Dependabot.

Regarding changes in the v4 version, I tried running both of your example steps:

- name: test 4.2.1
    uses: aws-actions/configure-aws-credentials@v4.2.1
        with: 
          role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
          aws-region: ${{ secrets.AWS_REGION }}

And

- name: test 4
        uses: aws-actions/configure-aws-credentials@v4
        with:
          role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
          aws-region: ${{ secrets.AWS_REGION }}

Both versions worked, and so I was unable to reproduce the error. Did you change anything else between running the two steps?

Nothing has changed in any part remotely connected to this. So nope.