fix: check lambda Function latest status in sdkupdate (#174)

Issue [#2433](aws-controllers-k8s/community#2433)

Description of changes:
This change ensures the Lambda Function does not get stuck in `pending`.
This issue occurs because we check the desired Status, which is not in
sync with the latest Status in AWS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: michaelhtm

pkg/resource/function/hooks.go

@@ -69,36 +69,38 @@ func (rm *resourceManager) customUpdateFunction(
 	exit := rlog.Trace("rm.customUpdateFunction")
 	defer exit(err)
 
-	if isFunctionPending(desired) {
-		return nil, requeueWaitWhilePending
+	updatedStatusResource := rm.concreteResource(desired.DeepCopy())
+	updatedStatusResource.SetStatus(latest)
+	if isFunctionPending(latest) {
+		return updatedStatusResource, requeueWaitWhilePending
 	}
 
 	if delta.DifferentAt("Spec.Tags") {
 		err = rm.updateFunctionTags(ctx, latest, desired)
 		if err != nil {
-			return nil, err
+			return updatedStatusResource, err
 		}
 	}
 	if delta.DifferentAt("Spec.ReservedConcurrentExecutions") {
 		err = rm.updateFunctionConcurrency(ctx, desired)
 		if err != nil {
-			return nil, err
+			return updatedStatusResource, err
 		}
 	}
 	if delta.DifferentAt("Spec.FunctionEventInvokeConfig") {
 		err = rm.syncFunctionEventInvokeConfig(ctx, desired)
 		if err != nil {
-			return nil, err
+			return updatedStatusResource, err
 		}
 	}
 	if delta.DifferentAt("Spec.CodeSigningConfigARN") {
 		if desired.ko.Spec.PackageType != nil && *desired.ko.Spec.PackageType == "Image" &&
 			desired.ko.Spec.CodeSigningConfigARN != nil && *desired.ko.Spec.CodeSigningConfigARN != "" {
-			return nil, ackerr.NewTerminalError(ErrCannotSetFunctionCSC)
+			return updatedStatusResource, ackerr.NewTerminalError(ErrCannotSetFunctionCSC)
 		} else {
 			err = rm.updateFunctionCodeSigningConfig(ctx, desired)
 			if err != nil {
-				return nil, err
+				return updatedStatusResource, err
 			}
 		}
 	}
@@ -112,9 +114,9 @@ func (rm *resourceManager) customUpdateFunction(
 		err = rm.updateFunctionCode(ctx, desired, delta, latest)
 		if err != nil {
 			if strings.Contains(err.Error(), "Provide a valid source image.") {
-				return nil, requeueWaitWhileSourceImageDoesNotExist
+				return updatedStatusResource, requeueWaitWhileSourceImageDoesNotExist
 			} else {
-				return nil, err
+				return updatedStatusResource, err
 			}
 		}
 	case delta.DifferentExcept(
@@ -125,13 +127,13 @@ func (rm *resourceManager) customUpdateFunction(
 		"Spec.CodeSigningConfigARN"):
 		err = rm.updateFunctionConfiguration(ctx, desired, delta)
 		if err != nil {
-			return nil, err
+			return updatedStatusResource, err
 		}
 	}
 
 	readOneLatest, err := rm.ReadOne(ctx, desired)
 	if err != nil {
-		return nil, err
+		return updatedStatusResource, err
 	}
 	return rm.concreteResource(readOneLatest), nil
 }

pkg/resource/function/sdk.go

@@ -51,5 +51,5 @@
 		ko.Spec.Tags = expectedOutput  
 	}
 	if err := rm.setResourceAdditionalFields(ctx, ko); err != nil {
-		return nil, err
-	}
+		return &resource{ko}, err
+	}