chore: Add missing PTENV to user agent #927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion context management. Add PTENV
pull-request-size
bot
added
the
size/XL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #927 +/- ##
===========================================
- Coverage 77.28% 77.26% -0.03%
===========================================
Files 272 271 -1
Lines 10875 10815 -60
Branches 1278 1274 -4
===========================================
- Hits 8405 8356 -49
+ Misses 2054 2043 -11
Partials 416 416 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…improve unit tests for assembly name handling
… assembly name parsing
1 task
dreamorosi
reviewed
Jul 18, 2025
libraries/src/AWS.Lambda.Powertools.Common/Core/PowertoolsEnvironment.cs
Outdated
Show resolved
Hide resolved
dreamorosi
reviewed
Jul 18, 2025
…ronment.cs Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com> Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
|
I believe the coverage is looking at the whole files, and to improve the coverage I would have to add more tests to cover other parts that are not touched on this pr, the pr itself (codecov/patch) is 100% covered |
dreamorosi
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #926
Summary
Changes
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.