From 5098db16e4db030c430cdf9e8ed330cde3eaaf35 Mon Sep 17 00:00:00 2001 From: John Date: Fri, 17 Jun 2022 14:08:31 -0400 Subject: [PATCH] Rename Local validate_true Functions to validate_false Some of the validate_true functions actually return false in some of the test cases and should be renamed for clarity. --- orders/tests/unit/test_create_order.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/orders/tests/unit/test_create_order.py b/orders/tests/unit/test_create_order.py index cf29c95..09c6f1c 100644 --- a/orders/tests/unit/test_create_order.py +++ b/orders/tests/unit/test_create_order.py @@ -254,12 +254,12 @@ def test_validate_fail(monkeypatch, lambda_module, order): Test validate() with failures """ - def validate_true(order: dict) -> Tuple[bool, str]: + def validate_false(order: dict) -> Tuple[bool, str]: return (False, "Something is wrong") - monkeypatch.setattr(lambda_module, "validate_delivery", validate_true) - monkeypatch.setattr(lambda_module, "validate_payment", validate_true) - monkeypatch.setattr(lambda_module, "validate_products", validate_true) + monkeypatch.setattr(lambda_module, "validate_delivery", validate_false) + monkeypatch.setattr(lambda_module, "validate_payment", validate_false) + monkeypatch.setattr(lambda_module, "validate_products", validate_false) error_msgs = asyncio.run(lambda_module.validate(order)) assert len(error_msgs) == 3 @@ -375,15 +375,15 @@ def test_handler_validation_failure(monkeypatch, lambda_module, context, order): Test handler() with failing validation """ - def validate_true(order: dict) -> Tuple[bool, str]: + def validate_false(order: dict) -> Tuple[bool, str]: return (False, "Something went wrong") def store_order(order: dict) -> None: pass - monkeypatch.setattr(lambda_module, "validate_delivery", validate_true) - monkeypatch.setattr(lambda_module, "validate_payment", validate_true) - monkeypatch.setattr(lambda_module, "validate_products", validate_true) + monkeypatch.setattr(lambda_module, "validate_delivery", validate_false) + monkeypatch.setattr(lambda_module, "validate_payment", validate_false) + monkeypatch.setattr(lambda_module, "validate_products", validate_false) monkeypatch.setattr(lambda_module, "store_order", store_order) user_id = order["userId"] @@ -397,4 +397,4 @@ def store_order(order: dict) -> None: print(response) assert response["success"] == False - assert len(response.get("errors", [])) > 0 \ No newline at end of file + assert len(response.get("errors", [])) > 0