Skip to content

Commit f37fa4e

Browse files
committed
fix: Request Parameters not picked up for v1 payload format with multivalue headers enabled (#1256)
1 parent 695dd06 commit f37fa4e

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

aws-serverless-java-container-springboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ private static HttpServletRequest generateRequest1(String request, Context lambd
120120
if (v1Request.getMultiValueQueryStringParameters() != null) {
121121
MultiValueMapAdapter<String, String> queryStringParameters = new MultiValueMapAdapter(v1Request.getMultiValueQueryStringParameters());
122122
queryStringParameters.forEach((k, v) -> {
123-
httpRequest.setParameter(k, v.toArray(new String[2]));
123+
httpRequest.setParameter(k, v.toArray(new String[0]));
124124
});
125125
}
126126

aws-serverless-java-container-springboot3/src/test/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtilsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ private static void assertRequest(HttpServletRequest request) {
233233
assertEquals("/async", request.getRequestURI());
234234
assertNotNull(request.getServletContext());
235235
// parameter handling for 2.0 requests is currently not spec compliant and to be fixed in future version
236-
// see also GitHub issue
236+
// see also GitHub issue https://github.com/aws/serverless-java-container/issues/1278
237237
if (!(request.getAttribute(RequestReader.HTTP_API_EVENT_PROPERTY) instanceof HttpApiV2ProxyRequest)) {
238238
assertEquals("value1", request.getParameter("parameter1"));
239239
assertArrayEquals(new String[]{"value1", "value2"}, request.getParameterValues("parameter1"));

aws-serverless-java-container-springboot3/src/test/java/com/amazonaws/serverless/proxy/spring/SpringDelegatingLambdaContainerHandlerTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,10 +215,10 @@ public void validateComplesrequest(String jsonEvent) throws Exception {
215215
handler.handleRequest(targetStream, output, null);
216216
Map result = mapper.readValue(output.toString(StandardCharsets.UTF_8), Map.class);
217217
assertEquals(200, result.get("statusCode"));
218-
String[] respponseBody = ((String) result.get("body")).split("/");
219-
assertEquals("male", respponseBody[0]);
220-
assertEquals("24", respponseBody[1]);
221-
assertEquals("Ricky", respponseBody[2]);
218+
String[] responseBody = ((String) result.get("body")).split("/");
219+
assertEquals("male", responseBody[0]);
220+
assertEquals("24", responseBody[1]);
221+
assertEquals("Ricky", responseBody[2]);
222222
}
223223

224224
@MethodSource("data")

0 commit comments

Comments
 (0)