Finish ICC ProfileSizeThreshold transformation

Author: Baspa

README.md

@@ -315,12 +315,15 @@ $url = $transformation->grayscale()->getUrl();
 The operation defines which RGB color profile sizes will be considered “small” and “large” when using srgb in `fast` or `icc` modes. The `number` stands for the ICC profile size in kilobytes.
 
 The default value is 10 (10240 bytes). Most of the common RGB profile sizes (sRGB, Display P3, ProPhoto, Adobe RGB, Apple RGB) are below the threshold.
+> Please note, that because this transformation should always be used in combinagtion with [`convertToSRGB()`](#convert-to-srgb) its method should be called <strong>after</strong> `convertToSRGB()`. Otherwise the ICC profile size threshold gets overwritten by the `convertToSRGB()` transformation.
 
 ```php
-$url = $transformation->iccProfileSizeThreshold(10)->getUrl();
-// https://example.com/cdn/.../max_icc_size/10/
+$url = $transformation->convertToSRGB('fast')->iccProfileSizeThreshold(10)->getUrl();
+// https://example.com/cdn/.../max_icc_size/50/srgb/fast
 ```
 
+
+
 ### Inverting 
 Inverts images rendering a 'negative' of the input.
 

src/Methods/Transformations.php

@@ -2,31 +2,32 @@
 
 namespace Vormkracht10\UploadcareTransformations\Methods;
 
-use Vormkracht10\UploadcareTransformations\Transformations\AutoRotate;
-use Vormkracht10\UploadcareTransformations\Transformations\BasicColorAdjustments;
 use Vormkracht10\UploadcareTransformations\Transformations\Blur;
-use Vormkracht10\UploadcareTransformations\Transformations\BlurFaces;
-use Vormkracht10\UploadcareTransformations\Transformations\BlurRegion;
-use Vormkracht10\UploadcareTransformations\Transformations\ConvertToSRGB;
 use Vormkracht10\UploadcareTransformations\Transformations\Crop;
-use Vormkracht10\UploadcareTransformations\Transformations\CropByObjects;
-use Vormkracht10\UploadcareTransformations\Transformations\CropByRatio;
-use Vormkracht10\UploadcareTransformations\Transformations\Enhance;
-use Vormkracht10\UploadcareTransformations\Transformations\Filter;
 use Vormkracht10\UploadcareTransformations\Transformations\Flip;
+use Vormkracht10\UploadcareTransformations\Transformations\Filter;
 use Vormkracht10\UploadcareTransformations\Transformations\Format;
 use Vormkracht10\UploadcareTransformations\Transformations\Mirror;
-use Vormkracht10\UploadcareTransformations\Transformations\Overlay;
-use Vormkracht10\UploadcareTransformations\Transformations\Progressive;
-use Vormkracht10\UploadcareTransformations\Transformations\Quality;
 use Vormkracht10\UploadcareTransformations\Transformations\Resize;
 use Vormkracht10\UploadcareTransformations\Transformations\Rotate;
-use Vormkracht10\UploadcareTransformations\Transformations\ScaleCrop;
+use Vormkracht10\UploadcareTransformations\Transformations\Enhance;
+use Vormkracht10\UploadcareTransformations\Transformations\Overlay;
+use Vormkracht10\UploadcareTransformations\Transformations\Quality;
 use Vormkracht10\UploadcareTransformations\Transformations\SetFill;
 use Vormkracht10\UploadcareTransformations\Transformations\Sharpen;
+use Vormkracht10\UploadcareTransformations\Transformations\BlurFaces;
+use Vormkracht10\UploadcareTransformations\Transformations\ScaleCrop;
 use Vormkracht10\UploadcareTransformations\Transformations\SmartCrop;
+use Vormkracht10\UploadcareTransformations\Transformations\AutoRotate;
+use Vormkracht10\UploadcareTransformations\Transformations\BlurRegion;
+use Vormkracht10\UploadcareTransformations\Transformations\CropByRatio;
+use Vormkracht10\UploadcareTransformations\Transformations\Progressive;
 use Vormkracht10\UploadcareTransformations\Transformations\SmartResize;
 use Vormkracht10\UploadcareTransformations\Transformations\ZoomObjects;
+use Vormkracht10\UploadcareTransformations\Transformations\ConvertToSRGB;
+use Vormkracht10\UploadcareTransformations\Transformations\CropByObjects;
+use Vormkracht10\UploadcareTransformations\Transformations\BasicColorAdjustments;
+use Vormkracht10\UploadcareTransformations\Transformations\ICCProfileSizeThreshold;
 
 class Transformations
 {

src/Transformations/ConvertToSRGB.php

@@ -29,13 +29,10 @@ public static function validate(string $key, ...$args): ?bool
 
     public static function generateUrl(string $url, array $values): string
     {
-
-        // if (isset($this->transformations['icc_profile_size_threshold'])) {
-        //     $transformation = $this->transformations['icc_profile_size_threshold'];
-
-        //     // -/max_icc_size/:number
-        //     $url .= '/max_icc_size/' . $transformation['number'];
-        // }
+        if (isset($values['size'])) {
+            // -/max_icc_size/:number
+            $url .= '/max_icc_size/' . $values['size'];
+        }
 
         // -/srgb/:profile
         $url .= '/srgb/' . $values['profile'];

src/Transformations/ICCProfileSizeThreshold.php

@@ -21,4 +21,10 @@ public static function validate(string $key, ...$args): ?bool
     {
         return null;
     }
+
+    public static function generateUrl(string $url, array $values): string
+    {
+        // We don't have to do anything here as it is already part of of the ConvertToSRGB transformation.
+        return $url;
+    }
 }

src/Transformations/TransformationsFinder.php

@@ -78,6 +78,21 @@ public static function for(array $transformations)
         $keys = array_keys($transformations);
 
         foreach ($keys as $transformation) {
+
+            // We need to check if ICCProfileSizeThreshold is used because it is a special case.
+            // This is because the URL transformation is a part of the ConvertToSRGB transformation.
+            if ($transformation === self::ICC_PROFILE_SIZE_THRESHOLD) {
+                $classes[self::CONVERT_TO_SRGB] = [
+                    'class' => self::getTransformation(self::CONVERT_TO_SRGB),
+                    'values' => [
+                        'profile' => $transformations[self::CONVERT_TO_SRGB]['profile'],
+                        'size' => $transformations[$transformation]['number'],
+                    ],
+                ];
+
+                continue;
+            }
+
             $classes[$transformation] = [
                 'class' => self::getTransformation($transformation),
                 'values' => $transformations[$transformation],