Skip to content

Commit cfd3887

Browse files
authored
Store Poetry binary in the cache (#835)
There was an issue in #827 where subsequent runs of the minimum dependencies job would fail due to a missing Poetry binary. I believe the cause of that was a missing cache path. The cache paths were copied from the other `run-tests` job which was also wrong, but which did not ever try to execute `poetry` binary directly so the missing binary issue was never discovered.
1 parent 36ec369 commit cfd3887

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

.github/workflows/run-tests.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,9 @@ jobs:
4747
.tox
4848
~/.cache/pip
4949
~/.cache/pypoetry
50+
~/.local/bin/poetry
5051
~/.local/share/pypoetry
51-
key: ${{ runner.os }}-python-${{ matrix.version }}-poetry-${{ hashFiles('pyproject.toml', 'tox.ini') }}
52+
key: ${{ runner.os }}-python-${{ matrix.version }}-poetry-${{ hashFiles('.github/workflows/run-tests.yml', 'pyproject.toml', 'tox.ini') }}
5253
- name: Install Poetry
5354
if: steps.cache-deps.outputs.cache-hit != 'true' && ! startsWith (matrix.os, 'windows')
5455
run: curl -sSL https://install.python-poetry.org | python3 -
@@ -102,17 +103,18 @@ jobs:
102103
with:
103104
python-version: ${{ matrix.version }}
104105
- name: Cache dependencies
105-
id: min-deps-test-cache-deps
106+
id: cache-deps
106107
uses: actions/cache@v3
107108
with:
108109
path: |
109110
.tox
110111
~/.cache/pip
111112
~/.cache/pypoetry
113+
~/.local/bin/poetry
112114
~/.local/share/pypoetry
113-
key: min-deps-test-${{ runner.os }}-python-${{ matrix.version }}-poetry-${{ hashFiles('pyproject.toml', 'tox.ini') }}
115+
key: min-deps-test-${{ runner.os }}-python-${{ matrix.version }}-poetry-${{ hashFiles('.github/workflows/run-tests.yml', 'pyproject.toml', 'tox.ini') }}
114116
- name: Install Poetry
115-
if: steps.min-deps-test-cache-deps.outputs.cache-hit != 'true'
117+
if: steps.cache-deps.outputs.cache-hit != 'true'
116118
run: curl -sSL https://install.python-poetry.org | python3 -
117119
- name: Install Tox
118120
run: |

0 commit comments

Comments
 (0)