Skip to content

Reduce Networking costs #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abi87 opened this issue Apr 14, 2025 · 1 comment · Fixed by #2687
Open

Reduce Networking costs #2666

abi87 opened this issue Apr 14, 2025 · 1 comment · Fixed by #2687
Assignees

Comments

@abi87
Copy link
Collaborator

abi87 commented Apr 14, 2025

A general issue to collect code changes or configuration suggestions to keep networking costs down.

  • Related to feat(p2p): tune SeedDisconnectWaitPeriod to Berachain cometbft#28.
    • TL:DR: seed nodes do not really respect max_num_outbound_peers limit; instead they periodically establish connections with peers from their address book and try and keep that connection active as long as needed for the peer to show it is a good peer (receiving 10_000 blocks or votes). The time to keep alive the connection is set to 28 hours in the code, which is what it is necessary for a 10 seconds block time chain. Berachain is faster and that time could be cut down to 6 hours
  • Related to feat(consensus): do not send Catchup Commit twice cometbft#27
    • Remove some edge cases where Comet sends duplicated Commits
  • Summarize CometBFT networking docs into a smaller internal runbook
@abi87 abi87 self-assigned this Apr 14, 2025
@abi87 abi87 linked a pull request Apr 16, 2025 that will close this issue
@abi87 abi87 reopened this Apr 16, 2025
@abi87
Copy link
Collaborator Author

abi87 commented Apr 16, 2025

Jotted down notes about CometBFT p2p system (with focus on address books and how to extract info from it) in. https://www.notion.so/berachain/Notes-on-CometBFT-address-book-1d76120abced80f5b04be375b761c804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant