Skip to content

Commit ebb4294

Browse files
phcoderani-sinha
authored andcommitted
* grub-core/disk/usbms.c (grub_usbms_cbi_cmd): Fix error type. (grub_usbms_cbi_reset): Likewise. (grub_usbms_bo_reset): Likewise. (grub_usbms_reset): Likewise. (grub_usbms_attach): Likewise. (grub_usbms_transfer_cbi): Likewise.
1 parent 0cc0d7a commit ebb4294

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

grub-core/disk/usbms.c

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ typedef struct grub_usbms_dev *grub_usbms_dev_t;
7676
static grub_usbms_dev_t grub_usbms_devices[MAX_USBMS_DEVICES];
7777
static int first_available_slot = 0;
7878

79-
static grub_err_t
79+
static grub_usb_err_t
8080
grub_usbms_cbi_cmd (grub_usb_device_t dev, int interface,
8181
grub_uint8_t *cbicb)
8282
{
@@ -86,7 +86,7 @@ grub_usbms_cbi_cmd (grub_usb_device_t dev, int interface,
8686
GRUB_USBMS_CBI_CMD_SIZE, (char*)cbicb);
8787
}
8888

89-
static grub_err_t
89+
static grub_usb_err_t
9090
grub_usbms_cbi_reset (grub_usb_device_t dev, int interface)
9191
{
9292
/* Prepare array with Command Block Reset (=CBR) */
@@ -108,7 +108,7 @@ grub_usbms_cbi_reset (grub_usb_device_t dev, int interface)
108108
return grub_usbms_cbi_cmd (dev, interface, (grub_uint8_t *)&cbicb);
109109
}
110110

111-
static grub_err_t
111+
static grub_usb_err_t
112112
grub_usbms_bo_reset (grub_usb_device_t dev, int interface)
113113
{
114114
grub_usb_err_t u;
@@ -118,7 +118,7 @@ grub_usbms_bo_reset (grub_usb_device_t dev, int interface)
118118
return GRUB_ERR_NONE;
119119
}
120120

121-
static grub_err_t
121+
static grub_usb_err_t
122122
grub_usbms_reset (grub_usbms_dev_t dev)
123123
{
124124
if (dev->protocol == GRUB_USBMS_PROTOCOL_BULK)
@@ -149,7 +149,7 @@ grub_usbms_attach (grub_usb_device_t usbdev, int configno, int interfno)
149149
int j;
150150
grub_uint8_t luns = 0;
151151
unsigned curnum;
152-
grub_usb_err_t err = GRUB_ERR_NONE;
152+
grub_usb_err_t err = GRUB_USB_ERR_NONE;
153153

154154
if (first_available_slot == ARRAY_SIZE (grub_usbms_devices))
155155
return 0;
@@ -567,7 +567,11 @@ grub_usbms_transfer_cbi (struct grub_scsi *scsi, grub_size_t cmdsize, char *cmd,
567567
}
568568
}
569569

570-
return err;
570+
571+
if (err)
572+
return grub_error (GRUB_ERR_IO, "USB error %d", err);
573+
574+
return GRUB_ERR_NONE;
571575
}
572576

573577

0 commit comments

Comments
 (0)