Added schema to update tags correctly

Author: wongband

backend/conduit/tags/serializers.py

@@ -26,6 +26,24 @@ def dump_Tag(self, data, **kwargs):
         return {'tag': data}
 
 
+class TagFormSchema(Schema):
+    tagname = fields.Str()
+    description = fields.Str()
+    slug = fields.Str()
+    old_slug = fields.Str()
+    icon = fields.Str()
+    modSetting = fields.Int()
+    tag = fields.Nested('self', exclude=('tag',), default=True, load_only=True)
+
+    @pre_load
+    def make_Tag(self, data, **kwargs):
+        return data['tag']
+
+    @post_dump
+    def dump_Tag(self, data, **kwargs):
+        return {'tag': data}
+
+
 class TagsSchema(TagSchema):
     class Meta:
         exclude = ('tagFollowers', 'moderators',)
@@ -49,5 +67,6 @@ def dump_Tag(self, data, **kwargs):
 
 
 tag_schema = TagSchema()
+tag_form_schema = TagFormSchema()
 tags_schemas = TagsSchema(many=True)
 tag_mebership_schema = TagMembershipSchema()

backend/conduit/tags/views.py

@@ -1,5 +1,5 @@
 from .models import Tags
-from .serializers import tag_schema, tag_mebership_schema
+from .serializers import tag_schema, tag_form_schema, tag_mebership_schema
 
 from conduit.decorators import isAdmin
 from conduit.exceptions import InvalidUsage
@@ -46,10 +46,10 @@ def get_tag(slug, **kwargs):
 
 @blueprint.route('/api/tags/<slug>', methods=('PUT',))
 @jwt_required
-@use_kwargs(tag_schema)
-@marshal_with(tag_schema)
-def update_tag(slug, **kwargs):
-    tag = Tags.query.filter_by(slug=slug).first()
+@use_kwargs(tag_form_schema)
+@marshal_with(tag_form_schema)
+def update_tag(old_slug, **kwargs):
+    tag = Tags.query.filter_by(slug=old_slug).first()
     if not tag:
         raise InvalidUsage.tag_not_found()
     tag.update(**kwargs)