Skip to content

Commit 77c06cf

Browse files
abyrne10abyrne10
authored
Add checks for analytics being initialised properly when not in debug mode (#12)
* Add placeholder in Config.xcconfig * Add checks on app launch for analytics secret and enabled state
1 parent f808ec7 commit 77c06cf

File tree

3 files changed

+22
-25
lines changed

3 files changed

+22
-25
lines changed

‎Big Sur Font Smoothing Toggler/AppDelegate.swift‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ class AppDelegate: NSObject, NSApplicationDelegate {
2121
self.mainWindowController = mainWindowController
2222

2323
#if !DEBUG
24-
AppCenter.start(withAppSecret: AppCenterConfig.secret, services: [Analytics.self, Crashes.self])
24+
let appCenterSecret = AppCenterConfig.secret
25+
guard appCenterSecret != "" else { fatalError("Failed to get AppCenter secret") }
26+
AppCenter.start(withAppSecret: appCenterSecret, services: [Analytics.self, Crashes.self])
27+
guard Analytics.enabled else { fatalError("Failed to enable analytics") }
2528
#endif
2629
}
2730

‎Big Sur Font Smoothing Toggler/Config.xcconfig‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,5 @@
77

88
// Configuration settings file format documentation can be found at:
99
// https://help.apple.com/xcode/#/dev745c5c974
10+
11+
APP_CENTER_SECRET =

‎Font Smoothing Adjuster.xcodeproj/project.pbxproj‎

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
532D4B1E25DD700500BF2C57 /* Localizable.strings in Resources */ = {isa = PBXBuildFile; fileRef = 532D4B2125DD700500BF2C57 /* Localizable.strings */; };
1515
532D4B1F25DD700500BF2C57 /* Localizable.strings in Resources */ = {isa = PBXBuildFile; fileRef = 532D4B2125DD700500BF2C57 /* Localizable.strings */; };
1616
533B9D2125C8428500EB561A /* Config.swift in Sources */ = {isa = PBXBuildFile; fileRef = 533B9D2025C8428500EB561A /* Config.swift */; };
17-
533B9D4D25C9AC9800EB561A /* AppCenterAnalytics in Frameworks */ = {isa = PBXBuildFile; productRef = 533B9D4C25C9AC9800EB561A /* AppCenterAnalytics */; };
1817
535090332562BD94005CCD39 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 535090322562BD94005CCD39 /* AppDelegate.swift */; };
1918
535090352562BD95005CCD39 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 535090342562BD95005CCD39 /* Assets.xcassets */; };
2019
535090382562BD95005CCD39 /* MainMenu.xib in Resources */ = {isa = PBXBuildFile; fileRef = 535090362562BD95005CCD39 /* MainMenu.xib */; };
@@ -29,10 +28,10 @@
2928
535090842562DE10005CCD39 /* FontSmoothingDefaults.swift in Sources */ = {isa = PBXBuildFile; fileRef = 535090832562DE10005CCD39 /* FontSmoothingDefaults.swift */; };
3029
535090852562DE10005CCD39 /* FontSmoothingDefaults.swift in Sources */ = {isa = PBXBuildFile; fileRef = 535090832562DE10005CCD39 /* FontSmoothingDefaults.swift */; };
3130
535090862562DE10005CCD39 /* FontSmoothingDefaults.swift in Sources */ = {isa = PBXBuildFile; fileRef = 535090832562DE10005CCD39 /* FontSmoothingDefaults.swift */; };
31+
53A9B3BE25E7B6560018E1FC /* AppCenterCrashes in Frameworks */ = {isa = PBXBuildFile; productRef = 53A9B3BD25E7B6560018E1FC /* AppCenterCrashes */; };
32+
53A9B3C025E7B6560018E1FC /* AppCenterAnalytics in Frameworks */ = {isa = PBXBuildFile; productRef = 53A9B3BF25E7B6560018E1FC /* AppCenterAnalytics */; };
3233
9308ED3925C32444008EC774 /* Sparkle.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 9308ED3825C32444008EC774 /* Sparkle.framework */; settings = {ATTRIBUTES = (Required, ); }; };
3334
9308ED3C25C3245C008EC774 /* Sparkle.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 9308ED3825C32444008EC774 /* Sparkle.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
34-
937ED7A425C31D01009FC993 /* AppCenterCrashes in Frameworks */ = {isa = PBXBuildFile; productRef = 937ED7A325C31D01009FC993 /* AppCenterCrashes */; };
35-
937ED7A625C31D01009FC993 /* AppCenterAnalytics in Frameworks */ = {isa = PBXBuildFile; productRef = 937ED7A525C31D01009FC993 /* AppCenterAnalytics */; };
3635
/* End PBXBuildFile section */
3736

3837
/* Begin PBXContainerItemProxy section */
@@ -103,9 +102,9 @@
103102
isa = PBXFrameworksBuildPhase;
104103
buildActionMask = 2147483647;
105104
files = (
106-
937ED7A625C31D01009FC993 /* AppCenterAnalytics in Frameworks */,
107105
9308ED3925C32444008EC774 /* Sparkle.framework in Frameworks */,
108-
937ED7A425C31D01009FC993 /* AppCenterCrashes in Frameworks */,
106+
53A9B3BE25E7B6560018E1FC /* AppCenterCrashes in Frameworks */,
107+
53A9B3C025E7B6560018E1FC /* AppCenterAnalytics in Frameworks */,
109108
);
110109
runOnlyForDeploymentPostprocessing = 0;
111110
};
@@ -120,7 +119,6 @@
120119
isa = PBXFrameworksBuildPhase;
121120
buildActionMask = 2147483647;
122121
files = (
123-
533B9D4D25C9AC9800EB561A /* AppCenterAnalytics in Frameworks */,
124122
);
125123
runOnlyForDeploymentPostprocessing = 0;
126124
};
@@ -212,8 +210,8 @@
212210
);
213211
name = "Font Smoothing Adjuster";
214212
packageProductDependencies = (
215-
937ED7A325C31D01009FC993 /* AppCenterCrashes */,
216-
937ED7A525C31D01009FC993 /* AppCenterAnalytics */,
213+
53A9B3BD25E7B6560018E1FC /* AppCenterCrashes */,
214+
53A9B3BF25E7B6560018E1FC /* AppCenterAnalytics */,
217215
);
218216
productName = "Big Sur Font Smoothing Toggler";
219217
productReference = 5350902F2562BD94005CCD39 /* Font Smoothing Adjuster.app */;
@@ -252,7 +250,6 @@
252250
);
253251
name = "Font Smoothing AdjusterUITests";
254252
packageProductDependencies = (
255-
533B9D4C25C9AC9800EB561A /* AppCenterAnalytics */,
256253
);
257254
productName = "Big Sur Font Smoothing TogglerUITests";
258255
productReference = 5350904A2562BD95005CCD39 /* Font Smoothing AdjusterUITests.xctest */;
@@ -293,7 +290,7 @@
293290
);
294291
mainGroup = 535090262562BD94005CCD39;
295292
packageReferences = (
296-
937ED7A225C31D01009FC993 /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */,
293+
53A9B3BC25E7B6560018E1FC /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */,
297294
);
298295
productRefGroup = 535090302562BD94005CCD39 /* Products */;
299296
projectDirPath = "";
@@ -552,7 +549,7 @@
552549
CODE_SIGN_IDENTITY = "Apple Development";
553550
CODE_SIGN_STYLE = Automatic;
554551
COMBINE_HIDPI_IMAGES = YES;
555-
CURRENT_PROJECT_VERSION = 1.2;
552+
CURRENT_PROJECT_VERSION = 1.2.1;
556553
DEVELOPMENT_TEAM = 4YNZUF26AM;
557554
ENABLE_HARDENED_RUNTIME = YES;
558555
FRAMEWORK_SEARCH_PATHS = (
@@ -564,7 +561,7 @@
564561
"$(inherited)",
565562
"@executable_path/../Frameworks",
566563
);
567-
MARKETING_VERSION = 1.2;
564+
MARKETING_VERSION = 1.2.1;
568565
PRODUCT_BUNDLE_IDENTIFIER = "com.bouncetechnologies.Font-Smoothing-Adjuster";
569566
PRODUCT_NAME = "$(TARGET_NAME)";
570567
SWIFT_VERSION = 5.0;
@@ -580,7 +577,7 @@
580577
CODE_SIGN_IDENTITY = "Apple Development";
581578
CODE_SIGN_STYLE = Automatic;
582579
COMBINE_HIDPI_IMAGES = YES;
583-
CURRENT_PROJECT_VERSION = 1.2;
580+
CURRENT_PROJECT_VERSION = 1.2.1;
584581
DEVELOPMENT_TEAM = 4YNZUF26AM;
585582
ENABLE_HARDENED_RUNTIME = YES;
586583
FRAMEWORK_SEARCH_PATHS = (
@@ -592,7 +589,7 @@
592589
"$(inherited)",
593590
"@executable_path/../Frameworks",
594591
);
595-
MARKETING_VERSION = 1.2;
592+
MARKETING_VERSION = 1.2.1;
596593
PRODUCT_BUNDLE_IDENTIFIER = "com.bouncetechnologies.Font-Smoothing-Adjuster";
597594
PRODUCT_NAME = "$(TARGET_NAME)";
598595
SWIFT_VERSION = 5.0;
@@ -729,7 +726,7 @@
729726
/* End XCConfigurationList section */
730727

731728
/* Begin XCRemoteSwiftPackageReference section */
732-
937ED7A225C31D01009FC993 /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */ = {
729+
53A9B3BC25E7B6560018E1FC /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */ = {
733730
isa = XCRemoteSwiftPackageReference;
734731
repositoryURL = "https://github.com/microsoft/appcenter-sdk-apple.git";
735732
requirement = {
@@ -740,19 +737,14 @@
740737
/* End XCRemoteSwiftPackageReference section */
741738

742739
/* Begin XCSwiftPackageProductDependency section */
743-
533B9D4C25C9AC9800EB561A /* AppCenterAnalytics */ = {
740+
53A9B3BD25E7B6560018E1FC /* AppCenterCrashes */ = {
744741
isa = XCSwiftPackageProductDependency;
745-
package = 937ED7A225C31D01009FC993 /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */;
746-
productName = AppCenterAnalytics;
747-
};
748-
937ED7A325C31D01009FC993 /* AppCenterCrashes */ = {
749-
isa = XCSwiftPackageProductDependency;
750-
package = 937ED7A225C31D01009FC993 /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */;
742+
package = 53A9B3BC25E7B6560018E1FC /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */;
751743
productName = AppCenterCrashes;
752744
};
753-
937ED7A525C31D01009FC993 /* AppCenterAnalytics */ = {
745+
53A9B3BF25E7B6560018E1FC /* AppCenterAnalytics */ = {
754746
isa = XCSwiftPackageProductDependency;
755-
package = 937ED7A225C31D01009FC993 /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */;
747+
package = 53A9B3BC25E7B6560018E1FC /* XCRemoteSwiftPackageReference "appcenter-sdk-apple" */;
756748
productName = AppCenterAnalytics;
757749
};
758750
/* End XCSwiftPackageProductDependency section */

0 commit comments

Comments
 (0)