Subqueries should clone QueryBuilder object

Nik Barham · Nik Barham · commit a1e6d5d8d3af · 2018-04-12T12:34:34.000Z
diff --git a/src/Database/QueryBuilder/SubQuery.php b/src/Database/QueryBuilder/SubQuery.php
@@ -22,7 +22,7 @@ class SubQuery extends Table
     public function __construct($query, ?string $alias = 'subquery')
     {
         if ($query instanceof QueryBuilder) {
-            $this->sub = $query;
+            $this->sub = clone $query;
         } elseif ($query instanceof SqlString) {
             $this->sql = (string) $query;
         } elseif (is_string($query)) {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class SubQuery extends Table`
`22`	`22`	`public function __construct($query, ?string $alias = 'subquery')`
`23`	`23`	`{`
`24`	`24`	`if ($query instanceof QueryBuilder) {`
`25`		`- $this->sub = $query;`
	`25`	`+ $this->sub = clone $query;`
`26`	`26`	`} elseif ($query instanceof SqlString) {`
`27`	`27`	`$this->sql = (string) $query;`
`28`	`28`	`} elseif (is_string($query)) {`