-
Notifications
You must be signed in to change notification settings - Fork 20
Feat(SPV-1546): delete user endpoint #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Manual TestsβΉοΈ Remember to ask team members to perform manual tests and to assign |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
==========================================
- Coverage 34.50% 34.45% -0.06%
==========================================
Files 437 438 +1
Lines 20826 20883 +57
==========================================
+ Hits 7186 7195 +9
- Misses 13041 13088 +47
- Partials 599 600 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
| ) | ||
|
|
||
| // DeleteCurrentUser attempts to delete current user | ||
| func (s *APIUsers) DeleteCurrentUser(c *gin.Context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe because only admin can create a user, maybe only admin should rather have power to remove the user
Pull Request Checklist