Skip to content

Conversation

@dzolt-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dzolt-4chain dzolt-4chain requested a review from a team as a code owner March 6, 2025 16:27
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.35484% with 50 lines in your changes missing coverage. Please review.

Project coverage is 34.45%. Comparing base (c5eea15) to head (aa41a2c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
engine/v2/database/repository/users.go 0.00% 19 Missing ⚠️
engine/v2/users/users_service.go 0.00% 13 Missing ⚠️
api/gen.api.go 0.00% 11 Missing ⚠️
actions/v2/users/remove.go 69.23% 3 Missing and 1 partial ⚠️
actions/v2/admin/users/get.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
- Coverage   34.50%   34.45%   -0.06%     
==========================================
  Files         437      438       +1     
  Lines       20826    20883      +57     
==========================================
+ Hits         7186     7195       +9     
- Misses      13041    13088      +47     
- Partials      599      600       +1     
Flag Coverage Ξ”
unittests 34.45% <19.35%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
actions/v2/users/current.go 46.66% <100.00%> (ΓΈ)
actions/v2/users/server.go 100.00% <100.00%> (ΓΈ)
actions/v2/admin/users/get.go 33.33% <0.00%> (-9.53%) ⬇️
actions/v2/users/remove.go 69.23% <69.23%> (ΓΈ)
api/gen.api.go 0.00% <0.00%> (ΓΈ)
engine/v2/users/users_service.go 0.00% <0.00%> (ΓΈ)
engine/v2/database/repository/users.go 0.00% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update c5eea15...aa41a2c. Read the comment docs.

πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

)

// DeleteCurrentUser attempts to delete current user
func (s *APIUsers) DeleteCurrentUser(c *gin.Context) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because only admin can create a user, maybe only admin should rather have power to remove the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants